Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value encoding problem with 'trusted-set-cookie' and 'trusted-set-cookie-reload' scriptlets #320

Closed
zloyden opened this issue May 30, 2023 · 1 comment
Closed

Value encoding problem with 'trusted-set-cookie' and 'trusted-set-cookie-reload' scriptlets #320

zloyden opened this issue May 30, 2023 · 1 comment
Assignees
@slavaleleka
Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@zloyden
Copy link

zloyden commented May 30, 2023 •
edited
Loading

AdguardTeam/AdguardFilters#152360.
There is a problem with this scriptlet. It adds a wrong value.

matkahuolto.fi#%#//scriptlet('trusted-set-cookie', 'CookieConsentV2', 'YES%2CTOI%2CANA%2CKOH')
Screenshot:

image


The expected behavior is shown in the screenshot below.

the correct value:

image
@zloyden zloyden added the bug Something isn't working label May 30, 2023
@adguard-bot adguard-bot changed the title matkahuolto.fi - issue with the trusted-set-cookie (or reload) scriptlets matkahuolto.fi - issue with the 'trusted-set-cookie' (or 'trusted-set-cookie') scriptlet May 30, 2023
@adguard-bot adguard-bot changed the title matkahuolto.fi - issue with the 'trusted-set-cookie' (or 'trusted-set-cookie') scriptlet Value encoding problem with 'trusted-set-cookie' and 'trusted-set-cookie-reload' scriptlets May 31, 2023
@slavaleleka
Copy link
Contributor

related to #311, the fix will be available in the upcoming scriptlets release

adguard pushed a commit that referenced this issue May 31, 2023
@slavaleleka
add one more test for trusted-set-cookie. #320 AG-22700
89bb841 
Squashed commit of the following:

commit 6964add
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 31 13:22:15 2023 +0300

    fix readme test section

commit 50a1fda
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 31 13:21:46 2023 +0300

    add one more test for trusted-set-cookie
@adguard-bot adguard-bot mentioned this issue Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adguard-bot @zloyden @slavaleleka