Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookie setting scriptlets — do not encode name and value #311

Closed
Alex-302 opened this issue Apr 16, 2023 · 1 comment
Closed

Fix cookie setting scriptlets — do not encode name and value #311

Alex-302 opened this issue Apr 16, 2023 · 1 comment
Assignees
@stanislav-atr
Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@Alex-302
Copy link
Member

Examples:

  • karofilm.ru#%#//scriptlet('trusted-set-cookie-reload', 'pop::138', '138')
Details

image

  • #%#//scriptlet('trusted-set-cookie', '__w_cc11', '{%22preferences%22:false%2C%22analysis%22:false%2C%22marketing%22:false}')
Details (second line)

image
@Alex-302 Alex-302 added the bug Something isn't working label Apr 16, 2023
@maximtop maximtop changed the title 'set-cookie' scripltet distorts some symbols, used as value 'set-cookie' scriptltet distorts some symbols, used as value Apr 26, 2023
@maximtop maximtop changed the title 'set-cookie' scriptltet distorts some symbols, used as value 'set-cookie' scriptlet distorts some symbols, used as value Apr 26, 2023
@adguard-bot adguard-bot assigned stanislav-atr and unassigned maximtop May 4, 2023
@adguard-bot adguard-bot changed the title 'set-cookie' scriptlet distorts some symbols, used as value Fix cookie setting scriptlets — do not encode name and value May 31, 2023
@slavaleleka
Copy link
Contributor

cookie name and value shall not be encoded by trusted-set-cookie and trusted-set-cookie-reload

@slavaleleka slavaleleka mentioned this issue May 31, 2023
Closed
@adguard-bot adguard-bot mentioned this issue Jul 27, 2023
Closed
@Alex-302 Alex-302 mentioned this issue Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislav-atr stanislav-atr

Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Alex-302 @maximtop @adguard-bot @slavaleleka @stanislav-atr