Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for $to and $from modifiers #60

Open
ameshkov opened this issue Jul 30, 2024 · 0 comments
Open

Add support for $to and $from modifiers #60

ameshkov opened this issue Jul 30, 2024 · 0 comments
Labels
enhancement New feature or request Priority: P4

Comments

@ameshkov
Copy link
Member

ameshkov commented Jul 30, 2024 •
edited
Loading

$to is a modifier that's applied to the request URL's domain name:
https://adguard.com/kb/general/ad-filtering/create-own-filters/#to-modifier

$from is just an alias for $domain

I am not entirely sure that $to can be implemented in Safari content blockers though, if-domain may only be applied to the main document domain, needs to be tested.

UPD: quick test shows that if-domain won't work indeed. Anyways, let's keep this issue open, maybe you can come up with an alternative solution.
@ameshkov ameshkov added the enhancement New feature or request label Jul 30, 2024
@ameshkov ameshkov mentioned this issue Jul 30, 2024
Open
adguard pushed a commit that referenced this issue Dec 16, 2024
@ameshkov
Added as an alias of : updates #60
3029e9d
adguard pushed a commit that referenced this issue Dec 17, 2024
@ameshkov
Pull request 104: x4 performance improvement + refactoring
bfc66d9 
Merge in ADGUARD-IOS/safari-converter from performance to master

* commit '77fee6d667ab0467860b9562e31faf66b79c2ba9': (49 commits)
  Fix review comments
  Applied suggestion
  Fix review comments
  Remove TODO
  Formatting, comments
  Improved readme, added changelog
  Improved code comments
  Added  as an alias of : updates #60
  start changelog
  solve todos
  Improved converter tests
  Improved SimpleRegex implementation, added tests
  Added test for ,badfilter
  Got rid of isBlockPopups
  Moved isDocumentWhitelist to NetworkRule
  Improved specifichide handling
  Moved subdocument validation to NetworkRule
  Moved logic for building result to Distributor
  Changed NetworkRule.ContentType to OptionSet
  Removed SafariService singleton, SafariVersion is now passed through
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Priority: P4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ameshkov @adguard-bot