-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove complicated heuristics for $domain modifier #1875
Comments
As I recall there were lots of $cookie rules that were using |
They can be converted to |
But are they converted in other filter lists? Like uBO lists for instance? |
uBO doesn't support |
Sorry, I may be confusing things now, but I recall that in uBO filters something similar was used for other rule types, maybe it was |
I don't remember, but I can say we uBO team always assume |
Got it, thank you! I generally like the idea and this whole heuristic was made for compatibility reasons back in the day. |
uBlockOrigin/uBOL-home#156 Somewhat related and AGMV3 is also affected. Do all the AG products now support |
All save for Safari-based: AdguardTeam/SafariConverterLib#60 (but I think it can't be properly implemented there anyway) |
It's a bit problematic if we have to use |
Safari most likely won't be able to apply |
Related problem with 3p filter |
I mean
This seems to be the culprit of false positive I fixed.
STR:
://www2.etc-$document,domain=com|net|icu
ETC利用照会サービス
ログイン
IMO the heuristics is no more needed, as we now have
$to
and it should be decided by filter author in actual context.The text was updated successfully, but these errors were encountered: