Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10 #215

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Release 0.10 #215

merged 5 commits into from
Jan 9, 2024

Conversation

Adanos020
Copy link
Owner

@Adanos020 Adanos020 commented Jan 8, 2024

Added

  • From (#211):
    • Tabs, the close tab buttons and the add tab buttons are now focusable with the keyboard and interactable with the enter key and space bar.
    • Separators are now focusable with the keyboard and movable using the arrow keys while control or shift is held.
    • TabStyle::active_with_kb_focus, TabStyle::inactive_with_kb_focus and TabStyle::focused_with_kb_focus for style of tabs that are focused with the keyboard.
  • Missing translation for the tooltip showing when you hover on a grayed out window close button. (#216)

Fixed

  • Widgets inside tabs are now focusable with the tab key on the keyboard. (#211)

Breaking changes

  • Upgraded to egui 0.25
  • Replaced Default implementations for {TabContextMenu,Window,}Translations with associated functions called english. (#216)

Adanos020 and others added 4 commits January 8, 2024 12:42
* Fix crash after calling `DockState::remove_tab`. (#208)

* Remove surface after removing the last remaining tab, if the surface isn't `Main`.

* Add explicit panic in `Tree::remove_leaf` if the `Tree` is empty.

* Bump patch version, update changelog.

* Include instructions on how to run examples in Readme. (#209)

* Fix keyboard focus not working inside `DockArea`s

* Add visual indicators when tab buttons are focused

* Allow current tab to be switched using the keyboard

* Remove extra focusable areas

I removed focus from two widgets that are not supposed to be focusable.
Also, I added highlighting to the separators when they are focused
because apparently I can't remove the ability to focus them without
breaking the ability to drag the separators.

* Separators can now be moved with the arrow keys

* Add highlighting to active tabs that are keyboard focused

* Update changelog

* Add tab styles for keyboard-focused tabs

* Don't move separators unless Ctrl or Shift is down

This is so that using the arrow keys to change the keyboard focus will
still work normally.

* Clippy

---------

Co-authored-by: Adam Gąsior <adanos020@gmail.com>
@alufers
Copy link

alufers commented Jan 8, 2024

Tested this PR with my app along with egui 0.25. No issues spotted, focusing close button with tab works. Great job! 👍

@Adanos020
Copy link
Owner Author

@alufers Nice one, thanks for testing it!

I'm holding off merging this until we merge #216, which shouldn't take too long.

* Add translation for window close button tooltip

* Rename `default` to `english` in `{TabContextMenu,Window,}Translations`

* Update changelog
@Adanos020 Adanos020 merged commit e07d9c4 into main Jan 9, 2024
8 checks passed
@Adanos020 Adanos020 deleted the release-0.10 branch February 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants