Keyboard focus fixes #211
Keyboard focus fixes #211
Conversation
* Remove surface after removing the last remaining tab, if the surface isn't `Main`. * Add explicit panic in `Tree::remove_leaf` if the `Tree` is empty.
|
Switching between widgets with the Tab key seems to work fine. I noticed that when you try to switch between tabs and their close buttons, it usually takes several presses of the Tab key to get from one tab to the next. I attempted to see if there was something else in focus, and sure enough, the value of @white-axe Do you have any ideas what might cause that? |
I removed focus from two widgets that are not supposed to be focusable. Also, I added highlighting to the separators when they are focused because apparently I can't remove the ability to focus them without breaking the ability to drag the separators.
|
There were some widgets that were requesting focus when they didn't need it. I couldn't figure out how to prevent the separators from being focused so for completeness I also added the ability to move them with the arrow keys when focused. |
|
This is a great improvement! One last thing I think would make this near perfect would be to highlight currently focused separators and tabs the same way they're highlighted on mouse hover. Then I think we can merge this. Also, if you could update the changelog with the fix and new feature for release 0.10, would be appreciated. |
|
There's now a visual indication of when an active tab is focused with the keyboard, although it just uses the "focused" tab style because there isn't a unique tab style for tabs that are active and hovered at the same time. I'm not sure what you mean by highlighting the currently focused separators. I think I already implemented highlighting them when focusing them with the keyboard. |
|
Hm, yeah, highlighted tabs now look exactly the same as the currently focused tab, i.e. one whose body you've last clicked on.
The only exception is when the currently hovered tab is in a node with multiple tabs and it's not the currently selected tab, then it'll have a brighter border. I think all tabs should behave like this, not just "secondary" ones.
Now for separators, I think last time I tested I saw the separators wouldn't get highlighted until you attempted to resize one. Although, that might not have actually been the case since now it doesn't behave this way. |
This is so that using the arrow keys to change the keyboard focus will still work normally.
|
Alright, I've added new styles for tabs that are focused with the keyboard. |
* Fix crash after calling `DockState::remove_tab`. (#208) * Remove surface after removing the last remaining tab, if the surface isn't `Main`. * Add explicit panic in `Tree::remove_leaf` if the `Tree` is empty. * Bump patch version, update changelog. * Include instructions on how to run examples in Readme. (#209) * Fix keyboard focus not working inside `DockArea`s * Add visual indicators when tab buttons are focused * Allow current tab to be switched using the keyboard * Remove extra focusable areas I removed focus from two widgets that are not supposed to be focusable. Also, I added highlighting to the separators when they are focused because apparently I can't remove the ability to focus them without breaking the ability to drag the separators. * Separators can now be moved with the arrow keys * Add highlighting to active tabs that are keyboard focused * Update changelog * Add tab styles for keyboard-focused tabs * Don't move separators unless Ctrl or Shift is down This is so that using the arrow keys to change the keyboard focus will still work normally. * Clippy --------- Co-authored-by: Adam Gąsior <adanos020@gmail.com>
* Bump crate version * Keyboard focus fixes (#211) * Fix crash after calling `DockState::remove_tab`. (#208) * Remove surface after removing the last remaining tab, if the surface isn't `Main`. * Add explicit panic in `Tree::remove_leaf` if the `Tree` is empty. * Bump patch version, update changelog. * Include instructions on how to run examples in Readme. (#209) * Fix keyboard focus not working inside `DockArea`s * Add visual indicators when tab buttons are focused * Allow current tab to be switched using the keyboard * Remove extra focusable areas I removed focus from two widgets that are not supposed to be focusable. Also, I added highlighting to the separators when they are focused because apparently I can't remove the ability to focus them without breaking the ability to drag the separators. * Separators can now be moved with the arrow keys * Add highlighting to active tabs that are keyboard focused * Update changelog * Add tab styles for keyboard-focused tabs * Don't move separators unless Ctrl or Shift is down This is so that using the arrow keys to change the keyboard focus will still work normally. * Clippy --------- Co-authored-by: Adam Gąsior <adanos020@gmail.com> * Upgrade to egui 0.25 (#214) * Update readme and changelog * Add window tooltip translation (#216) * Add translation for window close button tooltip * Rename `default` to `english` in `{TabContextMenu,Window,}Translations` * Update changelog --------- Co-authored-by: 刘皓 <whiteaxe@tuta.io>
This pull request closes #207 by fixing the behaviour of keyboard focus when using the Tab key on the keyboard.
I also added highlighting to the buttons in the tab titles when they are focused with the keyboard, and added the ability to change the current tab by focusing it with the keyboard and then pressing Enter or Space.
If you want me to update the changelog, let me know what I should put for the version.