Skip to content

build(deps): bump aw-webui for streaming exports - #765

Closed
TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:chore/bump-aw-webui-csv-export
Closed

TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:chore/bump-aw-webui-csv-export

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Summary

The pin stops at #997 and does not pull in later Activity-view work. aw-server-rust#722 already provides the matching /api/0/buckets/{id}/export/csv endpoint.

Verification

  • aw-webui#997 checks: build, lint, unit tests, CodeQL, and Greptile all green
  • cargo test -p aw-server --test api csv_export_returns_csv_with_correct_headers_and_missing_bucket_errors -- --nocapture

Local npm 11 install was not used because it rejects the existing git dependency with EALLOWGIT; this PR only advances the already-tested submodule pointer.

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Updates a git submodule dependency to a new commit.

No blocking issue was established, though the updated submodule contents were not available for review.

Summary

Advances the aw-webui submodule pin to include streamed JSON downloads and the server-side CSV export path.

  • No issue attributable to the pin change was established from the available code.

Reviews (1) · Last reviewed commit: "build(deps): bump aw-webui for streaming..."

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (656f3c9) to head (a905a22).
⚠️ Report is 163 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #765       +/-   ##
===========================================
+ Coverage   70.81%   82.09%   +11.27%     
===========================================
  Files          51       80       +29     
  Lines        2916    10084     +7168     
===========================================
+ Hits         2065     8278     +6213     
- Misses        851     1806      +955     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimeToBuildBob

TimeToBuildBob commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

Not reviewed

Confidence N/A

Not scored — this diff moves a submodule pointer and contains no source to assess. Treat it as not reviewed, not as approved.

ℹ️ Submodule pointer change only — not reviewed.

This diff moves a submodule SHA and contains no source changes, so there is nothing here for me to assess. Whether the bump is safe depends on the submodule's commit range, which this diff does not include. Treat this as not reviewed, not as approved.

Reviewed a905a22c725e · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 8s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Closing as superseded — master already carries this bump (and more).

  • dependabot ActivityWatch/aw-server-rust#770 merged 2026-10-01 (merge commit 8b7d92d) bumps aw-webui from 22cb53b → 56e8de7.
  • That is the same base (22cb53b) and a strict superset of this PR's target f5391fe: f5391fe is 9 commits behind 56e8de7, so 56e8de7 already contains aw-webui#993 (streamed JSON downloads) and aw-webui#997 (server-side CSV export).
  • Master's submodule pointer now reads 56e8de7, so rebasing this branch would leave an empty diff (and re-pointing back to f5391fe would be a regression).

The downstream motivation, ActivityWatch/aw-android#305, is now CLEAN and no longer blocked on this PR.

No rebase performed — there is nothing left to land here. Reopen if you'd rather pin to a different aw-webui revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant