Repository navigation
chore(submodule): bump aw-server-rust to master (c535d77) - #305
Conversation
Picks up ActivityWatch/aw-server-rust#721: send HTTP headers before serializing large exports, so "Export all buckets as JSON" on ~500k events opens the connection during processing instead of waiting for the full body. Native Android fetch (ActivityWatch#304) already streams the body to a cache file; without this bump it still blocks on headers until serialization finishes. Also picks up: - ActivityWatch/aw-server-rust#718 — aw-sync dedupe CLI (JNI path unused) - ActivityWatch/aw-server-rust#719 — aw-sync v2 writer, feature-flagged - ActivityWatch/aw-server-rust#720 — install-ndk.sh macOS readlink - aw-webui bump to #988 (not #993) ActivityWatch#228 Git-Session-Id: ba128b8a-fc85-51b5-90c0-4c7a4beaed85
Review guide (auto-posted)Structured warm-up for reviewers — what changed, what to run, where to look. Key files
Suggested verification
Known risks / watch points
Suggested review focus
Generated by |
|
The test already set hasMigratedHostname, but startup uses the distinct sanitizedHostnameMigratedTo flag. Without it, Java opens the 17MB seeded sqlite.db while the rust worker switches journal_mode to WAL, hits SQLITE_BUSY, panics, and leaves events/count returning 500. Git-Session-Id: 523c0c0e-38a3-5992-bcb3-bf6bf0d76080
|
E2E Logcat from run 35826089151: rust worker panics at Cause: the fixture set Pushed |
Git-Session-Id: 7e8e
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
|
E2E This PR only bumps |
UpgradeWithHistoryTest left the compiled INSERT statement open. SQLiteStatement holds a SQLiteClosable ref, so db.close() did not drop the last reference and the Java connection stayed alive. rust then panicked on the v6 exclusive index migration (`database is locked`) and events/count stayed 500 for the rest of the 60s wait. Also delete leftover -wal/-shm after close. Git-Session-Id: 858a0c7e-764d-5961-a03a-156ec4922b8d
|
E2E
Cause: the 17MB seed left its compiled Pushed |
…ealTap Git-Session-Id: 702c
|
E2E |
|
E2E The previous failure on Waiting on a maintainer merge (pull-only on this repo). Does not close #228 until a device confirms the large JSON export. |
🤖 AI code reviewSafe to merge — no P0/P1 findings on latest reviewUpdated after inline dispositions on finding threads — this is the current state; the verdict below is frozen at review time and is kept as the historical record of that pass. Finding disposition
Bumps the aw-server-rust submodule from 70ba50dd to c535d77a and adjusts the UpgradeWithHistoryTest instrumentation: sets the sanitizedHostnameMigratedTo preference, wraps the seed inserts in a try/finally that closes the compiled SQLiteStatement, and deletes the -wal/-shm files after closing the seeded database. Needs a look — P2 onlyConfidence 4/5 1 finding ·
|
| commit | score | findings | engine | when |
|---|---|---|---|---|
27ad04b43e67 |
5/5 | 0 | llm | 2026-09-25 10:27 UTC |
173e6335edec |
5/5 | 0 | llm | 2026-10-02 15:03 UTC |
173e6335edec |
5/5 | 0 | llm | 2026-10-09 03:05 UTC |
5cea4169cd2f |
4/5 | 2 | llm | 2026-10-10 03:22 UTC |
Reviewed 5cea4169cd2f · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 1099s · about this reviewer
Maintainer commands
@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.
Git-Session-Id: a2b5
…streaming CSV) Git-Session-Id: 888e
…ust-305-6013 Git-Session-Id: fc35e8e9-b0fa-4a6e-ba93-9b6c85e93881
Carries 14 merged server fixes since 9008520, including the idempotent v3->v4 key_value migration (#792), stopwatch commit-before-ack (#743), in-place re-import (#766), and negative-duration rejection. Git-Session-Id: fc35e8e9-b0fa-4a6e-ba93-9b6c85e93881
Refresh (2026-10-10)
Re-pointed to aw-server-rust master
c535d77and merged current aw-android master. Since the previous pin9008520, that adds 14 merged server commits, including:key_valuemigration is idempotent/apif4b4a1a6(2026-10-06)Android master still pins
70ba50d, so none of these reach the app until this merges. Not included yet: ActivityWatch/aw-webui#1061 (merged 2026-10-06 21:05, after the server's last aw-webui bump), which aw-android#321 items 3/7/8 need. That requires an aw-webui bump in aw-server-rust first, then a re-bump here.Summary
Bumps aw-server-rust submodule to 9008520 (master as of 2026-10-02), which includes:
Together these fix #228: Export button silently fails for large datasets.
Testing
Fixes #228