-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] 2.1.0 지역인증 UI 및 지역인증 리마인더 바텀시트 (#229) #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0a95612
[Feat] 변경된 LocalVerificationView GUI 반영 (#229)
cirtuare 5294a44
[Chore] 필요없는 LocalVerificationView 코드 삭제 (#229)
cirtuare 15bc37a
[Refactor] 재사용 가능한 SemiShortView & Type 구현 (#229)
cirtuare e9b6741
[Feat] navigateToOnboardingLocalVerification 메소드 추가 (#229)
cirtuare 668f6fe
[Feat] VerificationReminderViewController 구현 (#229)
cirtuare 0def95f
[Feat] 지역인증 리마인더 바텀시트 띄우는 로직 구현 (#229)
cirtuare 2beb3ef
[Fix] 온보딩 타입 지역인증 인증 불가 지역 알럿 변경 (#229)
cirtuare ae16488
[Fix] LocalMapView 레이아웃 변경 (#229)
cirtuare 8aea3b4
[Fix] 버튼 radius 적용 잘못되는 오류 수정 (#229)
cirtuare 76c77d7
[Feat] LocalVerificationView warningLabel 깜빡임 추가 (#229)
cirtuare beba079
[Fix] 지역인증 건너뛰기 시 온보딩으로 이동하도록 수정 (#229)
cirtuare b4e3fd7
[Fix] 지역인증 처음 건너뛰기한 시간 저장 (#229)
cirtuare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
ACON-iOS/ACON-iOS/Global/UIComponents/SemiShortModal/SemiShortModalType.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // | ||
| // SemiShortModalType.swift | ||
| // ACON-iOS | ||
| // | ||
| // Created by 이수민 on 7/18/25. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| enum SemiShortModalType: CaseIterable { | ||
|
|
||
| case localVerificationReminder | ||
| case withdrawalConfirmation | ||
|
|
||
| var title: String { | ||
| switch self { | ||
| case .localVerificationReminder: | ||
| return StringLiterals.LocalVerificationModal.title | ||
| case .withdrawalConfirmation: | ||
| return StringLiterals.WithdrawalConfirmation.title | ||
| } | ||
| } | ||
|
|
||
| var description: String { | ||
| switch self { | ||
| case .localVerificationReminder: | ||
| return StringLiterals.LocalVerificationModal.description | ||
| case .withdrawalConfirmation: | ||
| return StringLiterals.WithdrawalConfirmation.description | ||
| } | ||
| } | ||
|
|
||
| var cancelButtonTitle: String { | ||
| switch self { | ||
| case .localVerificationReminder: | ||
| return StringLiterals.LocalVerificationModal.cancel | ||
| case .withdrawalConfirmation: | ||
| return StringLiterals.WithdrawalConfirmation.cancelButtonTitle | ||
| } | ||
| } | ||
|
|
||
| var confirmButtonTitle: String { | ||
| switch self { | ||
| case .localVerificationReminder: | ||
| return StringLiterals.LocalVerificationModal.confirm | ||
| case .withdrawalConfirmation: | ||
| return StringLiterals.WithdrawalConfirmation.confirmButtonTitle | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SemiShortModalView로 합친 것 좋네요! 👍👍
🐿️🐿️🐿️
setLayout부분 62...73줄에서cancelButton, confirmButton의 height에 heightRatio가 곱해져있는 탓에 코너가 어그러지는 것 같습니다!
코너가 호 모양이 될 수 있도록 높이 44로 고정해주실 수 있나요?