[FEAT] 2.1.0 지역인증 UI 및 지역인증 리마인더 바텀시트 (#229) #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
approved these changes
Jul 21, 2025
| import UIKit | ||
|
|
||
| final class WithdrawalConfirmationView: GlassmorphismView { | ||
| final class SemiShortModalView: GlassmorphismView { |
Collaborator
There was a problem hiding this comment.
SemiShortModalView로 합친 것 좋네요! 👍👍
🐿️🐿️🐿️ setLayout 부분 62...73줄에서
cancelButton, confirmButton의 height에 heightRatio가 곱해져있는 탓에 코너가 어그러지는 것 같습니다!
코너가 호 모양이 될 수 있도록 높이 44로 고정해주실 수 있나요?
Comment on lines
81
to
80
| switch localVerificationViewModel.flowType { | ||
| case .onboarding: | ||
| self.showDefaultAlert(title: "알림", message: "현재 동네인증이 불가능한 지역에 있어요", okText: "온보딩으로 이동", completion: { | ||
| if let sceneDelegate = UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate { | ||
| sceneDelegate.window?.rootViewController = OnboardingViewController(flowType: .login) | ||
| } | ||
| }) | ||
| default: | ||
| self.showDefaultAlert(title: "알림", message: "현재 동네인증이 불가능한 지역에 있어요", okText: "홈으로 이동", completion: { | ||
| NavigationUtils.navigateToTabBar()}) | ||
| } | ||
| self.showDefaultAlert(title: "알림", message: "현재 지역인증이 불가능한 지역에 있어요", okText: "홈으로 이동", completion: { | ||
| NavigationUtils.navigateToTabBar()}) |
Collaborator
There was a problem hiding this comment.
🐿️🐿️🐿️
앱 첫 사용 유저일경우(온보딩프로세스) 지역인증 건너뛰면 온보딩 화면으로 가야하지 않나요?!
Contributor
Author
There was a problem hiding this comment.
이거 기획한테 디엠으로 물어봤는데 (디엠으로 물어본 이유: 자체 엣지 케이스 대응이라 피그마에 없어서, 안드랑 공유할 필요 X..! 이었는데 앞으로 스레드 팔게요 ㅠㅠ), 이제 지역인증 건너뛰기가 되면 홈으로 가게 돼서, 외국일 때도 홈으로 가게 하는 게 맞다고 판단했어요!
Comment on lines
+761
to
+774
| guard AuthManager.shared.hasToken else { return } | ||
| guard !AuthManager.shared.hasVerifiedArea else { return } | ||
|
|
||
| let lastAlertTime = UserDefaults.standard.object(forKey: "lastLocalVerificationAlertTime") as? Date | ||
| let now = Date() | ||
|
|
||
| if let lastTime = lastAlertTime { | ||
| let timeDifference = now.timeIntervalSince(lastTime) | ||
| let hourDifference = timeDifference / 3600 | ||
|
|
||
| if hourDifference < 24 { return } | ||
| // TODO: - QA 때 보여주기용 (릴리즈 시 삭제) | ||
| // if timeDifference < 10 { return } | ||
| } |
Collaborator
There was a problem hiding this comment.
🐿️
나중에 시간 비교 메소드를 Util에서 따로 구현해도 좋을 것 같네요!
현재 딥링크랑 SpotDetail 앰플에서도 같은 로직이 있어서요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
🚨 참고 사항
📸 스크린샷
💥 To be sure
🌰 Resolve issue