-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] 프로필 편집 UI, 닉네임 유효성 로직 수정 / GlassBorder 리팩토링 (#164) #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5ef719b
[Del, Add] 에셋 삭제 및 추가 (#164)
yurim830 ff86be2
[Fix] glassBorder가 userInteracton을 가로채는 문제 해결 (#164)
yurim830 85fb3ec
[Feat] ACTextField에 글래스모피즘 이니셜라이저 구현 (#164)
yurim830 738b0b5
[Chore] 닉네임, 생년월일 텍스트필드 스타일 수정 (#164)
yurim830 79391ff
[Chore] SpotSearch textField 생성자 수정 (#164)
yurim830 4a96e9f
[Chore]유효성 메시지 타입 2.0 수정 (#164)
yurim830 eceb085
[Chore] 유효성메시지 컴포넌트 2.0 수정 (#164)
yurim830 ddc1b51
[Refactor] 닉네임 검증 로직 수정 및 개선 (#164)
yurim830 27a1aa9
[Refactor] 메소드 분리 (#164)
yurim830 b315da8
[Fix] 닉네임 카운터 2.0 UI 적용, ScrollView height 오류 수정 (#164)
yurim830 be20eda
[Chore] 텍스트필드 보더 색 변경 코드 삭제 (#164)
yurim830 e00be52
[Chore] 닉네임, 생년월일 textField place holder 수정 (#164)
yurim830 f95d65b
[Fix] ACTextField 폰트 설정 오류 수정 (#164)
yurim830 a964bee
[Fix] 첫 진입 시 유효성 메시지 보이지 않게 처리(#164)
yurim830 e607b9e
[Fix] 유효성 메시지 표시되는 진짜 원인 찾아서 수정 (#164)
yurim830 46b610f
[Chore] 안 쓰는 메소드 삭제, 유효성메시지 인셋 수정 (#164)
yurim830 8e528e8
[Chore] 코드 정리 (#164)
yurim830 a06ba32
[Chore] 코드 정리 (#164)
yurim830 82124f0
[Fix] 프로필 편집 뷰 레이아웃 경고 해결 (#164)
yurim830 8162301
[Chore] 프로필수정API 변경사항 반영 (프로필이미지 required -> optional) (#164)
yurim830 58aba16
[Fix] GlassBorder static 선언으로 인한 문제 해결 (#164)
yurim830 3df2481
[Chore] 변수명 관련 코드리뷰 반영 (#164)
yurim830 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
...bal/Resources/Assets.xcassets/Icons/1.0/Basic/ic_error.imageset/ic_error_20.svg
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...cassets/Icons/1.0/Basic/ic_local_check_mark.imageset/ic_local check mark_20.svg
This file was deleted.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...c_local_check_mark.imageset/Contents.json → ...c_exclamation_mark.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
.../Assets.xcassets/Icons/2.0/ic_exclamation_mark.imageset/ic_exclamation_mark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion
2
...1.0/Basic/ic_error.imageset/Contents.json → ...ons/2.0/ic_success.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "ic_error_20.svg", | ||
| "filename" : "ic_success.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
|
|
||
3 changes: 3 additions & 0 deletions
3
...S/Global/Resources/Assets.xcassets/Icons/2.0/ic_success.imageset/ic_success.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cirtuare UIView+ GlassBorder 관련 추가 수정 사항 생겼습니다!
기존 코드에서는 glassBorder가 static으로 선언되어서 모든 뷰가 하나의 glassBorderView 인스턴스를 공유했습니다.
따라서 한 뷰에서 2개 이상의 glassBorder가 있을 때 UI 업데이트가 정상적으로 안 되는 문제가 있었습니다.
이에, Associated Object를 활용하여 각 뷰마다 고유한 glassBorderView 인스턴스를 가질 수 있도록 했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
최고 !!!