[FEAT] 프로필 편집 UI, 닉네임 유효성 로직 수정 / GlassBorder 리팩토링 (#164) #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
changed the title
cirtuare
approved these changes
Jun 6, 2025
Contributor
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
논의가 길어져서 복잡했을 텐데 고생했어요💗!!!!!
| // MARK: - UI Properties | ||
|
|
||
| private let firstIcon = UIImageView() | ||
| private let icon = UIImageView() |
Contributor
There was a problem hiding this comment.
🐿️
컨벤션에 따라 뒤에 -ImageView 붙여주시면 조금 더 보기 편할 것 같아요 !
Comment on lines
129
to
135
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
|
|
||
| if let glassBorderAttribute = glassBorderAttribute { | ||
| self.addGlassBorder(glassBorderAttribute) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
🐿️
여기서 글모 백그라운드 뷰 리프레시는 필요없었나요?!
static으로 선언되어, 한 뷰에서 glassBorder를 사용하는 뷰가 2개 이상 있을 때 remove, refresh가 제대로 적용 안 되었음
yurim830
commented
Jun 6, 2025
Comment on lines
+50
to
104
| //MARK: - GlassBorder 설정 | ||
|
|
||
| extension UIView { | ||
|
|
||
| private struct AssociatedKeys { | ||
| static var glassBorderView: UInt8 = 0 | ||
| } | ||
|
|
||
| private var glassBorderView: GlassmorphismView? { | ||
| get { | ||
| return objc_getAssociatedObject(self, &AssociatedKeys.glassBorderView) as? GlassmorphismView | ||
| } | ||
| set { | ||
| objc_setAssociatedObject(self, &AssociatedKeys.glassBorderView, newValue, .OBJC_ASSOCIATION_RETAIN_NONATOMIC) | ||
| } | ||
| } | ||
|
|
||
| /// 주의: bounds가 0이면 적용 안 됨 | ||
| func addGlassBorder(_ attributes: GlassBorderAttributes) { | ||
| self.layer.borderWidth = 0 | ||
|
|
||
| glassBorderView?.removeFromSuperview() | ||
|
|
||
| let outerPath = UIBezierPath(roundedRect: bounds, cornerRadius: attributes.cornerRadius) | ||
| let innerRect = bounds.insetBy(dx: attributes.width, dy: attributes.width) | ||
| let innerPath = UIBezierPath(roundedRect: innerRect, cornerRadius: max(0, attributes.cornerRadius - attributes.width/2)) | ||
| outerPath.append(innerPath.reversing()) | ||
|
|
||
| UIView.glassBorderView = GlassmorphismView(attributes.glassmorphismType) | ||
|
|
||
| self.addSubview(UIView.glassBorderView) | ||
| UIView.glassBorderView.snp.makeConstraints { | ||
|
|
||
| let newGlassBorderView = GlassmorphismView(attributes.glassmorphismType) | ||
| self.glassBorderView = newGlassBorderView | ||
|
|
||
| self.addSubview(newGlassBorderView) | ||
|
|
||
| newGlassBorderView.snp.makeConstraints { | ||
| $0.edges.equalToSuperview() | ||
| } | ||
|
|
||
| let maskLayer = CAShapeLayer() | ||
| maskLayer.path = outerPath.cgPath | ||
| maskLayer.fillRule = .evenOdd | ||
|
|
||
| let maskView = UIView(frame: bounds) | ||
| maskView.layer.addSublayer(maskLayer) | ||
| UIView.glassBorderView.mask = maskView | ||
| newGlassBorderView.mask = maskView | ||
|
|
||
| newGlassBorderView.isUserInteractionEnabled = false | ||
| } | ||
|
|
||
|
|
||
| func refreshGlassBorder() { | ||
| glassBorderView?.refreshBlurEffect() | ||
| } | ||
|
|
||
| func removeGlassBorder() { | ||
| UIView.glassBorderView.removeFromSuperview() | ||
| glassBorderView?.removeFromSuperview() | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@cirtuare UIView+ GlassBorder 관련 추가 수정 사항 생겼습니다!
기존 코드에서는 glassBorder가 static으로 선언되어서 모든 뷰가 하나의 glassBorderView 인스턴스를 공유했습니다.
따라서 한 뷰에서 2개 이상의 glassBorder가 있을 때 UI 업데이트가 정상적으로 안 되는 문제가 있었습니다.
이에, Associated Object를 활용하여 각 뷰마다 고유한 glassBorderView 인스턴스를 가질 수 있도록 했습니다.
yurim830
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
addGlassBorder메소드 오류 해결borderView가 user interaction을 가로채는 문제를 해결했습니다.
ACTextField글래스모피즘용 이니셜라이저를 구현->
업로드뷰 SearchTextField,프로필편집뷰 TextField에 적용프로필 편집 관련
📸 스크린샷
💥 To be sure
🌰 Resolve issue