Repository navigation
IPad drawing - #140
Merged
Merged
IPad drawing#140
Conversation
akaDuality
marked this pull request as draft
November 19, 2022 11:06
Open
2 of 5 tasks
…dDrawing # Conflicts: # Shared/Sources/Canvas/CanvasPresenter.swift # Shared/Sources/Document/Documents/VODesignDocument+UIKit.swift # Shared/Sources/Document/Documents/VODesignDocumentProtocol.swift # VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Canvas/VODesignPreviewView.swift # VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Canvas/VoiceOverElement.swift # VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Canvas/VoiceOverLayout.swift # VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Layout/VoiceOverElement.swift # VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/VoiceOverElement.swift
drucelweisse
marked this pull request as ready for review
December 14, 2022 18:21
akaDuality
commented
Dec 24, 2022
| #endif | ||
|
|
||
| public class A11yDescription: Codable, Equatable { | ||
| public class A11yDescription: Codable, Equatable, ObservableObject { |
Member
Author
There was a problem hiding this comment.
We should split A11yDescription to A11yDescription and A11yDescriptionDto. Dto will be data transfer object for saving to file, but regular A11yDescription will be used for rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.