integrate PINT pallets to mandela#1415
Closed
mattsse wants to merge 23 commits intoAcalaNetwork:masterfrom
Closed
Conversation
feat: integrate pint pallets into mandala runtime
Member
|
It is ok to use weights from PINT runtime for now. Before mainnet deployment we can do a re benchmarking. We have a WIP PR with chainlink integration #1073. It is a bit outdated and we will resume the work next week. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @xlc this is an initial proposal to integrate some of PINT's pallets into the mandela runtime.
Changes
pint_local_treasurypint_committeepint_asset_indexpint_saft_registrypint::PriceFeedforAggregatedDataProvider.TokenSymbol::PINT(we selected ID 169 randomly, perhaps an ID from the ecosystem range would be more suitable?)PintCommitteeConfigof the mandela chain specExistentialDepositsforTokenSymbol::PINTwas set toMAXfor karura, but we weren't sure for mandala.Also no XCM support at this point.
Integrating runtime-benchmarks needed some adapters to mitigate the missing chainlink pallet and support for acala's
CurrencyIdtype (TokenSymbol), because PINT relies on them for runtime benchmarks.Setting up chainlink feeds during runtime is a bit cumbersome if you have any feature suggestions I'm happy to get this included in the chainlink pallet directly.
If you have any questions, concerns, please reach out.
(CC @BenWhiteJam)
Also, FYI, there is a bug in prost that affects substrate's sc-consensus on polkadot-v0.9.9 (or rather libp2p 0.37.1) so nothing that depends on polkadot-v0.9.9 compiles currently with the latest rust nightly tokio-rs/prost#526