Skip to content

integrate PINT pallets to mandela#1415

Closed
mattsse wants to merge 23 commits intoAcalaNetwork:masterfrom
ChainSafe:add-pint
Closed

integrate PINT pallets to mandela#1415
mattsse wants to merge 23 commits intoAcalaNetwork:masterfrom
ChainSafe:add-pint

Conversation

@mattsse
Copy link

@mattsse mattsse commented Sep 15, 2021

Hey @xlc this is an initial proposal to integrate some of PINT's pallets into the mandela runtime.

Changes

  • add the PINT repo as submodule
  • implement some pallets for mandela
    • pint_local_treasury
    • pint_committee
    • pint_asset_index
    • pint_saft_registry
  • No chainlink pallet, instead implemented pint::PriceFeed for AggregatedDataProvider.
  • added TokenSymbol::PINT (we selected ID 169 randomly, perhaps an ID from the ecosystem range would be more suitable?)
  • Set Alice as PINT council member in the PintCommitteeConfig of the mandela chain spec
  • Reused the weights generated from the PINT runtime (wonder if we should copy them to the mandala weights folder?)
  • patched the orml repository url against the local submodule
  • The ExistentialDeposits for TokenSymbol::PINT was set to MAX for karura, but we weren't sure for mandala.

Also no XCM support at this point.

Integrating runtime-benchmarks needed some adapters to mitigate the missing chainlink pallet and support for acala's CurrencyId type (TokenSymbol), because PINT relies on them for runtime benchmarks.
Setting up chainlink feeds during runtime is a bit cumbersome if you have any feature suggestions I'm happy to get this included in the chainlink pallet directly.

If you have any questions, concerns, please reach out.
(CC @BenWhiteJam)

Also, FYI, there is a bug in prost that affects substrate's sc-consensus on polkadot-v0.9.9 (or rather libp2p 0.37.1) so nothing that depends on polkadot-v0.9.9 compiles currently with the latest rust nightly tokio-rs/prost#526

@xlc
Copy link
Member

xlc commented Sep 20, 2021

It is ok to use weights from PINT runtime for now. Before mainnet deployment we can do a re benchmarking.
The ED value could be something ~$0.01. If PITN starts with $1 evaluation, it can be 0.01 token.

We have a WIP PR with chainlink integration #1073. It is a bit outdated and we will resume the work next week.

@xlc xlc closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants