Closed
Conversation
Contributor
|
@wangjj9219 @xlc request review, can't actually request review because it is your pr ;). Reasonable initial integration of the pallet-chainlink-feed for testnet. I would say the chainlink pallet still needs a bit more work on the slashing mechanism for if an oracle is giving bad/malicious feeds (able to disable bad oracle but can't take awarded LINK). Adds LINK token (unsupported in karura/acala) and new chainlink types that need to be added to acala.js |
Member
|
Should be fine but will take a closer look later. I don't want to merge until Acala genesis is ready. |
|
What's the status of this PR? |
Member
|
It is on hold as waiting the chainlink pallet to be updated to latest Substrate version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1056