Updated ErrorStatusHandler to escalate more exceptions and added detail to ImageSequenceReference exceptions #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror and NotImplementedError and made ImageSequenceReference provide a more helpful exception message when trying to get a frame url from a zero rate or zero duration instance.
ssteinbach
approved these changes
Aug 20, 2020
Collaborator
ssteinbach
left a comment
ssteinbach
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the python errorStatusHandler to escalate details from IndexError and NotImplementedError and made ImageSequenceReference provide a more helpful exception message when trying to get a frame url from a zero rate or zero duration instance.
Split from #639, the docstring segment of that PR ended up handled elsewhere. This supersedes that PR.