Docstring/error messaging improvements for ImageSequenceReference #639
Conversation
…dation#602) Added ImageSequenceReference MediaReference subclass schema.
…oundation#633) * * Added initial support for `ImageSequenceReference` * * Added sample otio file with `ImageSequenceReference` * Added test for creating an rv session file with the sample file above * * Use the `frame_zero_padding` from the `ImageSequenceReference` in stead of `start_frame` for frame substitution base * * renamed _in and _out variables * * lint fix
Codecov Report
@@ Coverage Diff @@
## imagesequence #639 +/- ##
==============================================
Coverage 83.04% 83.04%
==============================================
Files 74 74
Lines 2860 2860
==============================================
Hits 2375 2375
Misses 485 485
Continue to review full report at Codecov.
|
…art_frame vs. image number.
…rror and NotImplementedError and made ImageSequenceReference provide a more helpful exception message when trying to get a frame url from a zero rate or zero duration instance.
reinecke
changed the title
| Frame step sets number of frames to "skip". For instance, if | ||
| ``start_frame`` is 1 and ``frame_step`` is 2, then the frame | ||
| number sequence will be 1, 3, 5, 7, etc. | ||
There was a problem hiding this comment.
This comment is great. The only thing I would add to it is a (admittedly pedantic) note about how the timing is implemented. IE played back at constant rate, but starting with the first frame in the sequence, which is on the screen for the time range [0, 1/rate), then the next image is shown for [1/rate, 2/rate) etc. This maps image files on disk to time ranges in the media time.
There was a problem hiding this comment.
Also any limitations on what the rate can be set to would be good to note here
|
This change looks like its good to go but needs to be rebased again, (sorry!). Then we should land it. |
|
Hey @reinecke can you rebase this PR? It would be great to land this. Sorry about the delay! |
7 participants
Adding docstrings to
ImageSequenceReferenceCPP bindings.