Pr/batched geometry attributes #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as checking a "while" loops condition variable before the condition had executed causing false positive. It was checking all elements of arrays causing false positives when only a subset of the array is actually being read from in "pointcloud_get", "spline", "splineinverse" calls. Implementation detail: in batched mode, to handle a varying count or knot count parameters a new version of osl_uninit_check_values_offset was added Fix message formatting for batched debug_uninit messages which was printing out pointer to the string instead of the strings themselves. Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
…ng interpolated integer arguments to be boolean when their default value is 0 or 1. In actuality the renderer could assign any integer value, we update BatchedAnalysis to track the interpolated value as a write event which will disqualify forcing of boolean as well as ensure future writes are masked properly. Added new lockgeom test that reproduces the issue and verifies its fixed. Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Mar 2, 2025
…wareFoundation#1949) Fix issue AcademySoftwareFoundation#1929 with batched execution forcing interpolated integer arguments to be boolean when their default value is 0 or 1. In actuality the renderer could assign any integer value, we update BatchedAnalysis to track the interpolated value as a write event which will disqualify forcing of boolean as well as ensure future writes are masked properly. Added new lockgeom test that reproduces the issue and verifies its fixed. --------- Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
lgritz
pushed a commit
that referenced
this pull request
Mar 5, 2025
Fix issue #1929 with batched execution forcing interpolated integer arguments to be boolean when their default value is 0 or 1. In actuality the renderer could assign any integer value, we update BatchedAnalysis to track the interpolated value as a write event which will disqualify forcing of boolean as well as ensure future writes are masked properly. Added new lockgeom test that reproduces the issue and verifies its fixed. --------- Signed-off-by: Alex M. Wells <alex.m.wells@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #1929 with batched execution forcing interpolated integer arguments to be boolean when their default value is 0 or 1.
In actuality the renderer could assign any integer value, we update BatchedAnalysis to track the interpolated value as a write event which will disqualify forcing it to be a boolean, as well as ensure future writes are masked properly.
Tests
Added new lockgeom test that reproduces the issue and verifies its fixed.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.