fix: make backfacing shadeop indicate backfacing shader-global is needed #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backfacing shadeop now directly accesses the backfacing field on the shader globals rather than calculating it from N and I. This updates the shader-globals-needed query to reflect that change. Signed-off-by: Stephen Friedman <sfriedma@pixar.com>
4 tasks
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Jun 24, 2024
…ded (AcademySoftwareFoundation#1827) The backfacing shadeop now directly accesses the backfacing field on the shader globals rather than calculating it from N and I. This updates the shader-globals-needed query to reflect that change. Signed-off-by: Stephen Friedman <sfriedma@pixar.com>
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
* fix: reparameter string needed to be ustringhash (AcademySoftwareFoundation#1841) * fix: make backfacing shadeop indicate backfacing shader-global is needed (AcademySoftwareFoundation#1827) * Fix the subsurface_bssrdf parameters (AcademySoftwareFoundation#1823) * Implement OpenPBR's sheen BRDF in testrender (AcademySoftwareFoundation#1819) * cleanup: OIIO deprecations (AcademySoftwareFoundation#1834) See merge request spi/dev/3rd-party/osl-feedstock!61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The backfacing shadeop now directly accesses the backfacing field on the shader globals rather than calculating it from N and I.
Tests
This updates the shader-globals-needed query to reflect that change.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.