Fix the subsurface_bssrdf parameters #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of single scattering parameters Signed-off-by: Chris Kulla <ckulla@gmail.com>
|
@jstone-lucasfilm @niklasharrysson this is for addressing the issue you brought up on slack. Let me know if the documentation looks ok. @lgritz The documentation exists in 3 places. I'm guessing the latex docs are deprecated, but is there anyway for the new md docs to use the header file somehow? |
|
The src/doc/*.md (particularly stdlib.md) is the primary documentation. The LaTeX is obsolete, and exists now only for us to double-check that the new docs have faithfully reproduced what we have. We don't yet have a way to generate docs from the headers, but it sure would be nice. (Open question: whether Doxygen can be coaxed into parsing osl headers so that we can use Sphinx + Breath + Doxygen like we do for the OIIO docs.) |
lgritz
approved these changes
Jun 10, 2024
niklasharrysson
approved these changes
Jun 11, 2024
chellmuth
pushed a commit
to chellmuth/OpenShadingLanguage
that referenced
this pull request
Sep 6, 2024
* fix: reparameter string needed to be ustringhash (AcademySoftwareFoundation#1841) * fix: make backfacing shadeop indicate backfacing shader-global is needed (AcademySoftwareFoundation#1827) * Fix the subsurface_bssrdf parameters (AcademySoftwareFoundation#1823) * Implement OpenPBR's sheen BRDF in testrender (AcademySoftwareFoundation#1819) * cleanup: OIIO deprecations (AcademySoftwareFoundation#1834) See merge request spi/dev/3rd-party/osl-feedstock!61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We intended this closure to take the effective color and radius so that the SSS color remapping can be controlled by the renderer.
Tests
The implementation in testrender uses a simple diffuse response (which was effectively assuming it got a multiple-scattered albedo. So all that was needed was renaming the parameters and updating docs.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.