Skip to content

#76 add spark.sql.shuffle.partitions to DefaultSparkConfiguration #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zejnilovic merged 2 commits into from
Jan 12, 2023
Merged

#76 add spark.sql.shuffle.partitions to DefaultSparkConfiguration #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b257b71
#76 add spark.sql.shuffle.partitions to DefaultSparkConfiguration
Zejnilovic Jan 12, 2023
8505421
#76 Fix codeowners
Zejnilovic Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
* @Zejnilovic
* @dk1844
* @benedeki
* @lsulak
* @Zejnilovic @dk1844 @benedeki @lsulak
Copy link
Contributor

@benedeki benedeki Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? Seems to me one person per line is easier to navigate. 🤔

Copy link
Contributor Author

@Zejnilovic Zejnilovic Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is syntactically wrong, it is a rule per line. Meaning that this is read as

  • Owner of everything is Zejnilovic
  • Owner of everything is dk1844
  • Owner of everything is benedeki
  • Owner of everything is lsulak

And the rules are overwriting each other, with the latest rule having priority. So @lsulak being the only code owner.

This is nice for custom rules but not for * rules.

Example of a smidge more complex CODEOWNERS

# Everything is owned by all of these guys
* @Zejnilovic @dk1844 @benedeki @lsulak

# Except for this, the test part is owned by miroslavpojer
spark-commons-test/* @miroslavpojer

Docs here

Copy link
Contributor Author

@Zejnilovic Zejnilovic Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

See the current state of this PR. Only lsulak is owner having the little shield next to his name.

Copy link
Contributor

@benedeki benedeki Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation 🙇

1 change: 1 addition & 0 deletions ...commons-test/src/main/scala/za/co/absa/spark/commons/test/DefaultSparkConfiguration.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,6 @@ object DefaultSparkConfiguration extends SparkTestConfig {
.config("spark.driver.host", "127.0.0.1")
.config("spark.sql.hive.convertMetastoreParquet", value = false)
.config("fs.defaultFS", "file:/")
.config("spark.sql.shuffle.partitions", "1")
}
}