#76 add spark.sql.shuffle.partitions to DefaultSparkConfiguration#77
#76 add spark.sql.shuffle.partitions to DefaultSparkConfiguration#77Zejnilovic merged 2 commits intomasterfrom
Conversation
The default of spark.sql.shuffle.partitions is 200. This commit sets it in the default testbase to 1.
lsulak
left a comment
lsulak
left a comment
There was a problem hiding this comment.
Of course, it makes sense.
I just read the code, not pulled/compiled/ran tests since this is a very small change code-wise.
| * @dk1844 | ||
| * @benedeki | ||
| * @lsulak | ||
| * @Zejnilovic @dk1844 @benedeki @lsulak |
There was a problem hiding this comment.
Why this change? Seems to me one person per line is easier to navigate. 🤔
There was a problem hiding this comment.
Because it is syntactically wrong, it is a rule per line. Meaning that this is read as
- Owner of everything is Zejnilovic
- Owner of everything is dk1844
- Owner of everything is benedeki
- Owner of everything is lsulak
And the rules are overwriting each other, with the latest rule having priority. So @lsulak being the only code owner.
This is nice for custom rules but not for * rules.
Example of a smidge more complex CODEOWNERS
# Everything is owned by all of these guys
* @Zejnilovic @dk1844 @benedeki @lsulak
# Except for this, the test part is owned by miroslavpojer
spark-commons-test/* @miroslavpojer
Docs here
There was a problem hiding this comment.
See the current state of this PR. Only lsulak is owner having the little shield next to his name.
There was a problem hiding this comment.
Thanks for the explanation 🙇
dk1844
left a comment
dk1844
left a comment
There was a problem hiding this comment.
LGTM (just read the code)
4 participants
Closes #76