[codex] Cover NOC low-disk handoffs in Knowledge#27
Conversation
a9e6ba4 to
a3ca3dd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3ca3dd231
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| disk_condition = ( | ||
| "low root filesystem" in lower_query | ||
| or "root filesystem condition" in lower_query | ||
| or ("filesystem" in lower_query and "disk" in lower_query) | ||
| ) |
There was a problem hiding this comment.
Match common BGP snapshot low-disk wording
When the handoff is phrased by the incident itself, e.g. prevent BGP router snapshots from filling root filesystem or low disk on noc bgp-router-snapshot, disk_condition is false because these checks require either the exact low root filesystem wording or both filesystem and disk. Since snapshot_condition alone is not enough, those queries miss the new exact postmortem boost and return unrelated BGP/API or host refs instead of the curated retention context, so the new NOC low-disk coverage only works for the eval's narrow phrasing.
Useful? React with 👍 / 👎.
Summary
Dependency
Validation