Skip to content

[codex] Cover NOC low-disk handoffs in Knowledge#27

Merged
Svaag merged 1 commit into
mainfrom
feat/noc-disk-handoff-knowledge-coverage
Jul 1, 2026
Merged

[codex] Cover NOC low-disk handoffs in Knowledge#27
Svaag merged 1 commit into
mainfrom
feat/noc-disk-handoff-knowledge-coverage

Conversation

@Svaag

@Svaag Svaag commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add reviewed OKF context for the noc BGP snapshot root filesystem incident
  • seed retrieval for NOC low-root-filesystem/BGP snapshot handoff tasks so the context pack includes the specific postmortem instead of only generic host refs
  • add retrieval and Engineering Loop context-pack evals, then refresh exports, eval reports, and quality reports

Dependency

  • Source ref points at AS215932/network-operations commit e0e643a1f5e1fefdb458478e468fbf6b3bca13b2 from network-operations PR #336.

Validation

  • uv run ruff check src tests
  • uv run pytest
  • uv run hyrule-knowledge validate okf
  • uv run hyrule-knowledge export --check
  • uv run hyrule-knowledge eval --check
  • uv run hyrule-knowledge quality --check
  • uv run hyrule-knowledge ledger --check
  • uv run hyrule-knowledge ledger lifecycle --check
  • uv run mypy --strict src
  • uv run hyrule-knowledge scan-secrets okf exports reports evals ledger schema

@Svaag Svaag force-pushed the feat/noc-disk-handoff-knowledge-coverage branch from a9e6ba4 to a3ca3dd Compare July 1, 2026 02:49
@Svaag Svaag marked this pull request as ready for review July 1, 2026 02:58
@Svaag Svaag merged commit bb2ed6e into main Jul 1, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3ca3dd231

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +346 to +350
disk_condition = (
"low root filesystem" in lower_query
or "root filesystem condition" in lower_query
or ("filesystem" in lower_query and "disk" in lower_query)
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match common BGP snapshot low-disk wording

When the handoff is phrased by the incident itself, e.g. prevent BGP router snapshots from filling root filesystem or low disk on noc bgp-router-snapshot, disk_condition is false because these checks require either the exact low root filesystem wording or both filesystem and disk. Since snapshot_condition alone is not enough, those queries miss the new exact postmortem boost and return unrelated BGP/API or host refs instead of the curated retention context, so the new NOC low-disk coverage only works for the eval's narrow phrasing.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant