Skip to content

[codex] Promote Knowledge handoff coverage#337

Merged
Svaag merged 1 commit into
mainfrom
promotion/knowledge-bb2ed6e
Jul 1, 2026
Merged

[codex] Promote Knowledge handoff coverage#337
Svaag merged 1 commit into
mainfrom
promotion/knowledge-bb2ed6e

Conversation

@Svaag

@Svaag Svaag commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Promotion

App PRs:

  • AS215932/knowledge PR 27 -> bb2ed6e7385f698849ebede2e29b24b16ac39fc0

Pinned versions:

  • noc_knowledge_version: 5a6666cbb9d290868db3fb854ffed39099515b91 -> bb2ed6e7385f698849ebede2e29b24b16ac39fc0
  • knowledge_mcp_version: b7863d9b810826ea25a954cc673cc9297472e5df -> bb2ed6e7385f698849ebede2e29b24b16ac39fc0
  • knowledge_loop_version: b7863d9b810826ea25a954cc673cc9297472e5df -> bb2ed6e7385f698849ebede2e29b24b16ac39fc0

Deploy impact:

  • Affected playbooks after merge: icinga2/mon, monitoring/noc, noc/noc, and engineering-loop/loop via app-promotion-deploy.
  • Expected service refreshes: NOC Knowledge export refresh, Knowledge MCP container rebuild/restart, and Knowledge Loop runtime checkout refresh.
  • Operator-visible behavior: Reliability Governor and NOC context retrieval should include the curated NOC BGP snapshot retention handoff/postmortem from Knowledge PR 27.

Rollback:

  • Previous noc_knowledge_version: 5a6666cbb9d290868db3fb854ffed39099515b91
  • Previous knowledge_mcp_version: b7863d9b810826ea25a954cc673cc9297472e5df
  • Previous knowledge_loop_version: b7863d9b810826ea25a954cc673cc9297472e5df

Validation:

  • Knowledge main CI is green for bb2ed6e7385f698849ebede2e29b24b16ac39fc0.
  • scripts/ci/iac-static.sh passes locally.
  • scripts/ci/render-all.sh passes locally outside the sandbox; ansible/generated/ remains clean.
  • scripts/ci/deploy-preflight.sh --repo-only passes locally.
  • Promotion PR CI is green.
  • Production app-promotion-deploy gate approved after merge.
  • Icinga pre/post snapshot diff reviewed.

Note: this is a manual promotion fallback because the current promote-apps workflow does not accept AS215932/knowledge inputs.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit cd372fb)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Verify shared version compatibility

The commit hash bb2ed6e7385f698849ebede2e29b24b16ac39fc0 is now used for both
knowledge_mcp_version and knowledge_loop_version. Verify that this single revision
correctly satisfies both the read-only Knowledge MCP server and the Governed
Knowledge Loop producer agent requirements, as they serve different purposes.

ansible/inventory/host_vars/loop.yml [20]

+knowledge_mcp_version: "bb2ed6e7385f698849ebede2e29b24b16ac39fc0"
 
-
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the same commit hash is now used for both knowledge_mcp_version and knowledge_loop_version, but it only asks the user to verify compatibility without providing a concrete improvement, limiting its impact.

Low
Confirm feature compatibility with comment

The comment above knowledge_loop_version references a specific Knowledge revision
that ships agent-core v0.4.0 sink_from_env support. Confirm that the new commit
bb2ed6e7385f698849ebede2e29b24b16ac39fc0 still includes these required features and
the Docker git runtime dependency fix (AS215932/knowledge#25).

ansible/inventory/host_vars/loop.yml [46]

+knowledge_loop_version: "bb2ed6e7385f698849ebede2e29b24b16ac39fc0"
 
-
Suggestion importance[1-10]: 5

__

Why: The suggestion appropriately notes the need to verify that the new commit still includes the required features mentioned in the comment, but it is a verification request rather than a code change, which limits its score.

Low

Svaag commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

PR-Agent's ticket-compliance section is a false-positive autolink: the 27 reference is the merged AS215932/knowledge PR, not a network-operations issue. This PR is only a Knowledge SHA promotion.

@Svaag Svaag marked this pull request as ready for review July 1, 2026 03:15
@Svaag Svaag requested a review from a team as a code owner July 1, 2026 03:15
@Svaag Svaag merged commit e0132b3 into main Jul 1, 2026
12 checks passed
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit cd372fb

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Verify shared version compatibility

The commit hash bb2ed6e7385f698849ebede2e29b24b16ac39fc0 is now used for both
knowledge_mcp_version and knowledge_loop_version. Verify that this single revision
correctly satisfies both the read-only Knowledge MCP server and the Governed
Knowledge Loop producer agent requirements, as they serve different purposes.

ansible/inventory/host_vars/loop.yml [20]

+knowledge_mcp_version: "bb2ed6e7385f698849ebede2e29b24b16ac39fc0"
 
-
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the same commit hash is now used for both knowledge_mcp_version and knowledge_loop_version, but it only asks the user to verify compatibility without providing a concrete improvement, limiting its impact.

Low
Confirm feature compatibility with comment

The comment above knowledge_loop_version references a specific Knowledge revision
that ships agent-core v0.4.0 sink_from_env support. Confirm that the new commit
bb2ed6e7385f698849ebede2e29b24b16ac39fc0 still includes these required features and
the Docker git runtime dependency fix (AS215932/knowledge#25).

ansible/inventory/host_vars/loop.yml [46]

+knowledge_loop_version: "bb2ed6e7385f698849ebede2e29b24b16ac39fc0"
 
-
Suggestion importance[1-10]: 5

__

Why: The suggestion appropriately notes the need to verify that the new commit still includes the required features mentioned in the comment, but it is a verification request rather than a code change, which limits its score.

Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant