System stats - API addition #6821

deepikabhavnani · 2018-05-04T15:52:21Z

Description

System Stats Addition. ~~Dependent on previous PR's. (Commits valid post ec71e4641cd24b4d9993ebf9f487cbe24d014441)~~

Status : ~~Work in progress~~ Done

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

cmonr · 2018-05-07T16:01:03Z

@deepikabhavnani Is this blocked on #508?

deepikabhavnani · 2018-05-07T16:30:28Z

@cmonr - This is not dependent on "Thread/System API addition #508" which is on Handbook. But should be merged post #6795

deepikabhavnani · 2018-05-11T15:17:16Z

Rebased on top of master.. No PR dependency now.

deepikabhavnani · 2018-05-11T18:12:50Z

@SenRamakri - Please review

0xc0170 · 2018-05-14T09:37:01Z

/morph build

mbed-ci · 2018-05-14T10:27:56Z

Build : SUCCESS

Build number : 1998
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6821/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

deepikabhavnani · 2018-05-14T14:59:25Z

@0xc0170 - Command used in build does not contain ALL flags enabled. Will have to re-run once @studavekar does that change.

studavekar · 2018-05-14T15:26:59Z

@0xc0170 - Command used in build does not contain ALL flags enabled. Will have to re-run once @studavekar does that change.

We should be good to run trigger the build on this PR, Logs from one of the PR

https://mbed-os.s3-eu-west-1.amazonaws.com/builds/6832/PASS/DISCO_F303VC/GCC_ARM/6154fd259845423b63fd8cc6a06f4798f3dd115e_build_log_DISCO_F303VC_GCC_ARM.txt

new command line looks like mbed test --compile -m <target> -t <toolchain> -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 -DMBED_ALL_STATS_ENABLED

mbed-ci · 2018-05-14T16:52:46Z

Exporter Build : SUCCESS

Build number : 1651
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6821/

mbed-ci · 2018-05-14T17:31:59Z

Test : SUCCESS

Build number : 1809
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6821/1809

cmonr · 2018-05-14T21:28:06Z

/morph build

Rerunning to use new build parameters.

mbed-ci · 2018-05-14T21:56:56Z

Build : FAILURE

Build number : 2016
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6821/

bulislaw

One thing I would like to add to the stats is the Mbed OS version.

0xc0170 · 2018-05-15T10:11:34Z

mbed OS version +1

to consider to be having in system stats if we have there mbed OS version - #6897 - having sha available or dirty flag, this might not be related to this one?

deepikabhavnani · 2018-05-15T15:02:07Z

@bulislaw Will add Mbed OS version.

@0xc0170 - I am not sure if we can add SHA, but can look upon that in future.

API added to get the system information like CPU ID, compiler ID and compiler version.

deepikabhavnani · 2018-05-15T15:19:21Z

Rebased, added Mbed OS version and resolved Cortex-A compilation issue.

CPUID base register is available for Cortex-M processors only. Cortex-A devices have Main ID Register, which can be used in future to get processor info.

deepikabhavnani · 2018-05-16T14:40:59Z

Testing build to confirm Cortex-A issues resolved.

/morph build

mbed-ci · 2018-05-16T15:44:01Z

Build : SUCCESS

Build number : 2037
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6821/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-16T18:35:34Z

Exporter Build : SUCCESS

Build number : 1685
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6821/

mbed-ci · 2018-05-16T22:49:03Z

Test : FAILURE

Build number : 1846
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6821/1846

cmonr · 2018-05-17T01:15:31Z

/morph test

mbed-ci · 2018-05-17T09:30:13Z

Test : SUCCESS

Build number : 1854
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6821/1854

cmonr · 2018-05-18T03:10:30Z

@0xc0170 @SenRamakri @bulislaw Are y'all alright with the updated changes?

deepikabhavnani added needs: work needs: preceding PR labels May 4, 2018

deepikabhavnani changed the title ~~System stats~~ System stats - API addition May 4, 2018

deepikabhavnani mentioned this pull request May 4, 2018

Update Statistics document - Thread/System/CPU API addition ARMmbed/mbed-os-5-docs#508

Merged

deepikabhavnani force-pushed the system_stats branch 2 times, most recently from 930274b to 4209608 Compare May 7, 2018 15:03

deepikabhavnani requested a review from SenRamakri May 8, 2018 14:44

deepikabhavnani mentioned this pull request May 9, 2018

CPU Statistics #6857

Merged

deepikabhavnani force-pushed the system_stats branch 3 times, most recently from 2e3a0d7 to f4395bc Compare May 11, 2018 15:16

deepikabhavnani removed the needs: preceding PR label May 11, 2018

SenRamakri previously approved these changes May 11, 2018

View reviewed changes

0xc0170 previously approved these changes May 14, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels May 14, 2018

cmonr added needs: work release-version: 5.9.0-rc1 labels May 14, 2018

cmonr removed the needs: CI label May 14, 2018

bulislaw previously approved these changes May 15, 2018

View reviewed changes

deepikabhavnani added 2 commits May 15, 2018 10:17

System Info API addition

c08b3e3

API added to get the system information like CPU ID, compiler ID and compiler version.

Added test for mbed_stats_sys_get() API

40021eb

deepikabhavnani dismissed stale reviews from bulislaw, 0xc0170, and SenRamakri via 8f5cfd0 May 15, 2018 15:18

deepikabhavnani force-pushed the system_stats branch from f4395bc to 8f5cfd0 Compare May 15, 2018 15:18

OS version added + CPUID for cortex-M only

1961428

CPUID base register is available for Cortex-M processors only. Cortex-A devices have Main ID Register, which can be used in future to get processor info.

deepikabhavnani force-pushed the system_stats branch from 8f5cfd0 to 1961428 Compare May 15, 2018 15:22

deepikabhavnani added needs: review and removed needs: work labels May 15, 2018

bmcdonnell-ionx mentioned this pull request May 17, 2018

#defines for git info #6897

Closed

bulislaw approved these changes May 18, 2018

View reviewed changes

0xc0170 approved these changes May 18, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels May 18, 2018

cmonr merged commit 97b1615 into ARMmbed:master May 21, 2018

cmonr removed the ready for merge label May 21, 2018

deepikabhavnani deleted the system_stats branch May 30, 2018 17:58

System stats - API addition #6821

System stats - API addition #6821

Uh oh!

Conversation

deepikabhavnani commented May 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr commented May 7, 2018

Uh oh!

deepikabhavnani commented May 7, 2018

Uh oh!

deepikabhavnani commented May 11, 2018

Uh oh!

deepikabhavnani commented May 11, 2018

Uh oh!

0xc0170 commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Triggering tests

Uh oh!

deepikabhavnani commented May 14, 2018

Uh oh!

studavekar commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Uh oh!

cmonr commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 15, 2018

Uh oh!

deepikabhavnani commented May 15, 2018

Uh oh!

deepikabhavnani commented May 15, 2018

Uh oh!

deepikabhavnani commented May 16, 2018

Uh oh!

mbed-ci commented May 16, 2018

Triggering tests

Uh oh!

mbed-ci commented May 16, 2018

Uh oh!

mbed-ci commented May 16, 2018

Uh oh!

cmonr commented May 17, 2018

Uh oh!

mbed-ci commented May 17, 2018

Uh oh!

cmonr commented May 18, 2018

Uh oh!

Uh oh!

deepikabhavnani commented May 4, 2018 •

edited

Loading