Thread stats API #6795

deepikabhavnani · 2018-05-02T21:40:23Z

Description

Addition of API to get information of all active threads in Mbed OS.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

CC @SenRamakri

Dependent on #6784

SenRamakri · 2018-05-03T08:24:29Z

TESTS/mbed_platform/stats_thread/main.cpp

+    t2.terminate();
+
+    count = mbed_stats_thread_get_each(stats, MAX_THREAD_STATS);
+    TEST_ASSERT_EQUAL(3, count);


@deepikabhavnani - You may want to check for the difference in the number of threads and not the absolute count. Because if we start running more threads as part of test infrastructure or for any other reason this test may break.

SenRamakri · 2018-05-03T08:26:22Z

platform/mbed_stats.c

-#warning Stack statistics are currently not supported without the rtos.
+size_t mbed_stats_thread_get_each(mbed_stats_thread_t *stats, size_t count)
+{
+    MBED_ASSERT(stats != NULL);


Should we also assert for if count == 0, for debug builds?

In case of count 0, we will not fill up anything. But in case of NULL pointer, next operation in the code is memset which should not be performed on NULL pointer.

0xc0170 · 2018-05-03T08:31:28Z

platform/mbed_stats.h

+    uint32_t thread_stack_size;     /**< Thread Stack Size */
+    uint32_t thread_stack_space;    /**< Thread remaining stack size */
+    const char   *thread_name;      /**< Thread Object name */
+} mbed_stats_thread_t;


Do we need to repeat thread_ prefix ?

mbed_stats_thread_t says this contains tread stats. all members are related to the thread (if not they would be a separate object?). Thus would be thread_stats.id/state/priority oppose to thread_stats.thread_id ?

0xc0170 · 2018-05-03T08:32:56Z

platform/mbed_stats.h

+ *  @param stats    A pointer to an array of mbed_stats_thread_t structures to fill
+ *  @param count    The number of mbed_stats_thread_t structures in the provided array
+ *  @return         The number of mbed_stats_thread_t structures that have been filled,
+ *                  this is equal to the number of stacks on the system.


this is equal to the number of stacks on the system - I do not understand stacks in this context? how many stacks we have? not threads here?

deepikabhavnani · 2018-05-03T15:58:22Z

@0xc0170 @SenRamakri - Pushed commits addressing review comments.

cmonr · 2018-05-08T16:18:52Z

/morph build

mbed-ci · 2018-05-08T16:56:06Z

Build : SUCCESS

Build number : 1947
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-08T18:46:34Z

Test : FAILURE

Build number : 1768
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6795/1768

mbed-ci · 2018-05-09T16:31:16Z

Build : SUCCESS

Build number : 1965
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-09T19:49:15Z

Test : FAILURE

Build number : 1779
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6795/1779

cmonr · 2018-05-09T20:17:25Z

/morph test

deepikabhavnani · 2018-05-09T20:34:45Z

@cmonr - As per the build log, MBED_ALL_STATS_ENABLED was not enabled. Can kill test.

mbed-ci · 2018-05-09T22:48:46Z

Exporter Build : FAILURE

Build number : 1616
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6795/

API to get all system threads information and states.

1. Removed prefix thread_ from all elements of mbed_stats_thread_t 2. #if conditions aligned to rest of the file

1. Enable watermark to get stack space information 2. Restructured code 3. Throw error if MBED_THREAD_STATS_ENABLED is not set 4. Astyle changes

deepikabhavnani · 2018-05-11T15:09:47Z

Rebased to resolve conflict

deepikabhavnani · 2018-05-11T17:45:45Z

@SenRamakri @0xc0170 - Please review

0xc0170 · 2018-05-14T09:27:13Z

/morph build

mbed-ci · 2018-05-14T10:03:39Z

Build : SUCCESS

Build number : 1997
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

deepikabhavnani · 2018-05-14T14:58:51Z

@0xc0170 - Command used in build does not contain ALL flags enabled. Will have to re-run once @studavekar does that change.

studavekar · 2018-05-14T15:37:54Z

re-triggering

/morph build

mbed-ci · 2018-05-14T16:06:58Z

Build : SUCCESS

Build number : 2005
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-15T01:41:12Z

Exporter Build : SUCCESS

Build number : 1657
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6795/

mbed-ci · 2018-05-15T02:47:55Z

Test : SUCCESS

Build number : 1815
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6795/1815

deepikabhavnani mentioned this pull request May 2, 2018

Add common define MBED_ALL_STATS_ENABLED to enable all statistics #6784

Merged

0xc0170 added the needs: review label May 3, 2018

0xc0170 requested a review from SenRamakri May 3, 2018 07:10

SenRamakri reviewed May 3, 2018

View reviewed changes

0xc0170 requested changes May 3, 2018

View reviewed changes

deepikabhavnani requested a review from 0xc0170 May 3, 2018 15:55

0xc0170 added needs: work and removed needs: review labels May 3, 2018

deepikabhavnani mentioned this pull request May 3, 2018

Update Statistics document - Thread/System/CPU API addition ARMmbed/mbed-os-5-docs#508

Merged

0xc0170 previously approved these changes May 4, 2018

View reviewed changes

deepikabhavnani added needs: review and removed needs: work labels May 4, 2018

deepikabhavnani mentioned this pull request May 7, 2018

System stats - API addition #6821

Merged

cmonr added the needs: preceding PR label May 7, 2018

SenRamakri previously approved these changes May 8, 2018

View reviewed changes

cmonr removed the needs: preceding PR label May 8, 2018

cmonr added needs: CI release-version: 5.9.0-rc1 and removed needs: review labels May 8, 2018

cmonr added needs: work and removed needs: CI labels May 8, 2018

deepikabhavnani added needs: CI needs: work and removed needs: work release-version: 5.9.0-rc1 labels May 8, 2018

deepikabhavnani force-pushed the thread_stats branch from 27ca65c to c651d82 Compare May 9, 2018 21:21

deepikabhavnani added 4 commits May 11, 2018 10:05

Thread statistics addition.

1dad739

API to get all system threads information and states.

Checking difference in thread count + review comments

bb8ccbd

Cleaup and review comments addressed

f43b16f

1. Removed prefix thread_ from all elements of mbed_stats_thread_t 2. #if conditions aligned to rest of the file

Cleanup

97c8818

1. Enable watermark to get stack space information 2. Restructured code 3. Throw error if MBED_THREAD_STATS_ENABLED is not set 4. Astyle changes

deepikabhavnani force-pushed the thread_stats branch from c651d82 to 97c8818 Compare May 11, 2018 15:09

SenRamakri approved these changes May 11, 2018

View reviewed changes

0xc0170 approved these changes May 14, 2018

View reviewed changes

0xc0170 added release-version: 5.9.0-rc1 and removed needs: work labels May 14, 2018

0xc0170 added the needs: CI label May 14, 2018

cmonr added ready for merge and removed needs: CI labels May 15, 2018

cmonr merged commit 46c1e94 into ARMmbed:master May 15, 2018

deepikabhavnani deleted the thread_stats branch May 15, 2018 15:08

cmonr removed the ready for merge label May 21, 2018

Thread stats API #6795

Thread stats API #6795

Uh oh!

Conversation

deepikabhavnani commented May 2, 2018

Description

Pull request type

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SenRamakri May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepikabhavnani commented May 3, 2018

Uh oh!

cmonr commented May 8, 2018

Uh oh!

mbed-ci commented May 8, 2018

Triggering tests

Uh oh!

mbed-ci commented May 8, 2018

Uh oh!

mbed-ci commented May 9, 2018

Triggering tests

Uh oh!

mbed-ci commented May 9, 2018

Uh oh!

cmonr commented May 9, 2018

Uh oh!

deepikabhavnani commented May 9, 2018

Uh oh!

mbed-ci commented May 9, 2018

Uh oh!

deepikabhavnani commented May 11, 2018

Uh oh!

deepikabhavnani commented May 11, 2018

Uh oh!

0xc0170 commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Triggering tests

Uh oh!

deepikabhavnani commented May 14, 2018

Uh oh!

studavekar commented May 14, 2018

Uh oh!

mbed-ci commented May 14, 2018

Triggering tests

Uh oh!

mbed-ci commented May 15, 2018

Uh oh!

mbed-ci commented May 15, 2018

Uh oh!

Uh oh!

SenRamakri May 3, 2018 •

edited

Loading