-
Notifications
You must be signed in to change notification settings - Fork 3k
RTOS : Add Message Pipe #5160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTOS : Add Message Pipe #5160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting your previous PR into two distinct PRs.
@c1728p9 Every class in rtos folder depends on NonCopyable from mbed platform,I think its same case here too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've approved the wrong PR, comments will follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it would fit platform directory more, I would like to keep rtos directory with RTX primitives or thin utilities.
Also can you work on docs? Especially the overall description -> if I don't know anything and I read the class description I should understand what I can do with this class.
We would also like to have some unit tests for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo:
- links to API docs
- unit tests
I get that it blurs RTOS and platform but Given this depends on RTOS, how does it not fit in the RTOS directory (if you remove RTOS is still works but otherwise you cant)? This would be the first RTOS tied change that I'm aware of platform directory.
@YarivCol Can you please respond to comments? |
Yes, I will modify the docs and add unit test. |
Let us know once done |
@AnotherButler New API. |
Build : FAILUREBuild number : 85 |
@YarivCol Any update on this ? |
Please reopen once it is up to date with the changes requested above are answered. |
Description
Message Pipe is FileHandle abstraction over rtos Mail.
It will be provide the user with ability to build more generic ITC or test code that use FileHandles
#5158 should be merged before this one.