Skip to content

RTOS : added empty and full functions to Mail and Queue #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2017
Merged

RTOS : added empty and full functions to Mail and Queue #5158

merged 4 commits into from
Nov 2, 2017

Conversation

YarivCol
Copy link
Contributor

Description

Functions to allow the user to know the state of the queue or mail

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2017

cc @bulislaw @c1728p9 @pan-

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting your previous PR into two distinct PRs.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1445

Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 2, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1495

Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2017

@studavekar I am not able to reproduce the failure above. It does not look related to this changeset (link errors for one toolchain for big callback test).

My test command to reproduce:

mbed test --compile -m REALTEK_RTL8195AM -t IAR -n features-frameworks-utest-tests-unit_tests-basic_test_default -DMBED_MEM_TRACING_ENABLED=1 -DMBED_HEAP_STATS_ENABLED=1

Build successes:
  * REALTEK_RTL8195AM::IAR::FEATURES-FRAMEWORKS-UTEST-TESTS-UNIT_TESTS-BASIC_TEST_DEFAULT
  * REALTEK_RTL8195AM::IAR::MBED-BUILD

I can see that there is similar error to another failure in #5220 (comment) Unknown toolchain for memory statistics IAR. The function that contains this report, however returns none and in another link function in tools , I do not see how this would cause an error in post processing.

I've noticed however another error here:

12:10:37 rt7M_tl.a'I/O error(28): No space left on device
12:10:37 Traceback (most recent call last):
12:10:37   File "C:\mj\workspace\bm_wrap\1587\mbed-os\tools\test_api.py", line 2114, in build_test_worker
12:10:37     bin_file = build_project(*args, **kwargs)
12:10:37   File "C:\mj\workspace\bm_wrap\1587\mbed-os\tools\build_api.py", line 578, in build_project
12:10:37     cur_result["memory_usage"] = memap_instance.mem_report
12:10:37 AttributeError: 'NoneType' object has no attribute 'mem_report'
12:10:37 ode  Gb  rom.o'I/O error(28): No space left on device
12:10:37 Traceback (most recent call last):
12:10:37   File "C:\mj\workspace\bm_wrap\1587\mbed-os\tools\test_api.py", line 2114, in build_test_worker
12:10:37     bin_file = build_project(*args, **kwargs)
12:10:37   File "C:\mj\workspace\bm_wrap\1587\mbed-os\tools\build_api.py", line 578, in build_project
12:10:37     cur_result["memory_usage"] = memap_instance.mem_report
12:10:37 AttributeError: 'NoneType' object has no attribute 'mem_report'

cc @theotherjimmy

Based on the above, I assume this fails because there is no space on the device.

@bulislaw
Copy link
Member

bulislaw commented Oct 4, 2017

Ah on a side note, @YarivCol could you extend tests for the new functions?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2017

Set as needs: work, any new API should add tests as requested above

@theotherjimmy
Copy link
Contributor

@0xc0170 It looks like tests were added. Are you happy with these tests?

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2017

Build : SUCCESS

Build number : 20
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5158/

@theotherjimmy
Copy link
Contributor

@AnotherButler More New APIs

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2017

Build : FAILURE

Build number : 86
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5158/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

/morph build

1 similar comment
@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2017

Build : SUCCESS

Build number : 290
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5158/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2017

Build : SUCCESS

Build number : 293
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5158/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2017

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2017

@YarivCol
Copy link
Contributor Author

@0xc0170 what is the status of this PR ?, do i need to fix something for it to be merged ?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2017

@0xc0170 what is the status of this PR ?, do i need to fix something for it to be merged ?

Waiting for CI to be completed.

/morph build

@adbridge
Copy link
Contributor

Looks like this didn't re-run.
/morph build

@adbridge
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2017

@theotherjimmy
Copy link
Contributor

@studavekar could you remove the invalid "AWS-CI uVisor Build & Test mbedos-5325"?

@theotherjimmy theotherjimmy merged commit 3a05b63 into ARMmbed:master Nov 2, 2017
@studavekar
Copy link
Contributor

@theotherjimmy github doesn't like changing status once merged, all status are marked as passed : https://api.github.com/repos/ARMmbed/mbed-os/statuses/e0a0615038f6cc491644ad6fc162eb4f2ab7aa41

@theotherjimmy
Copy link
Contributor

That's fine. Thanks for looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants