Skip to content

CMake: Use mbedtools build subcommand in travis CI #13821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CMake: Use mbedtools build subcommand in travis CI #13821

wants to merge 1 commit into from

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Use the tools as intended for end-users

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba force-pushed the hk_cmake_use_build_command branch from 793507c to 218f360 Compare October 27, 2020 17:11
@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Oct 27, 2020 •
edited
Loading

Closing because mbedtools build is missing an option to specify the build profile.
Created ARMmbed/mbed-tools#97 (comment)

@hugueskamba hugueskamba reopened this Oct 28, 2020
@hugueskamba hugueskamba force-pushed the hk_cmake_use_build_command branch from 218f360 to 43490eb Compare October 28, 2020 10:54
@hugueskamba
CMake: Use mbedtools build subcommand in travis CI
b56e096 
Use the tools as intended for end-users
@hugueskamba hugueskamba force-pushed the hk_cmake_use_build_command branch from 43490eb to b56e096 Compare October 28, 2020 10:54
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 28, 2020

I'll close this as we are going to test with Jenkins instead (PR #13477) - please review that PR if it contains the same command

@0xc0170 0xc0170 closed this Oct 28, 2020
@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Oct 28, 2020 •
edited
Loading

I'll close this as we are going to test with Jenkins instead (PR #13477) - please review that PR if it contains the same command

Added comment here: #13477 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 Awaiting requested review from 0xc0170

@rajkan01 rajkan01 Awaiting requested review from rajkan01

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugueskamba @0xc0170