CMake: add CI testing #13477

jamesbeyond · 2020-08-23T17:26:10Z

Summary of changes

added a new examples_cmake.json for describing which example can build with cmake on which targets
improved example.py let it support both cmake build and legency tools build

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-08-23T17:30:25Z

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

mbed-ci · 2020-08-23T17:54:44Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️

0xc0170 · 2020-08-24T08:32:30Z

I've checked the logs, there are only unit tests.

jamesbeyond · 2020-08-24T09:31:19Z

I've checked the logs, there are only unit tests.

Hi @0xc0170 , this is just for demo purpose, in the PR, I want to show that we can customize our CI pipeline, to a different flow/testing set on a particular branch, which is totally different from the master branch one.
This is the request from @Patater, I'll talk with him later regarding this.

mbed-ci · 2020-08-24T20:58:23Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️

mergify · 2020-08-24T21:18:28Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

mergify · 2020-08-28T14:22:13Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

mergify · 2020-09-02T11:09:54Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

mbed-ci · 2020-09-10T16:58:42Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️

mbed-ci · 2020-09-10T21:26:02Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️

mbed-ci · 2020-09-10T22:32:08Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️

mbed-ci · 2020-09-11T08:17:48Z

Jenkins CI Test : ❌ FAILED

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_unittests	✔️

mbed-ci · 2020-09-11T08:27:40Z

Jenkins CI Test : ❌ FAILED

Build Number: 7 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌
jenkins-ci/mbed-os-ci_unittests	✔️

ladislas · 2020-10-28T09:37:56Z

We are currently having issue with Travis being slow - lot of pending jobs (CMake jobs do not help as they take a lot of time and this won't scale anyway). As there are changes requested above, please also add a commit removing Travis CMake build job.

@0xc0170 I haven't looked into your Travis CI configuration, but I was having the same issue with our custom CI using CMake and rebuilding everything from scratch (we're using Github Actions).

We've added ccache to our build system and main CMakeLists.txt and now build that used to take ~10min on an old MacBook Pro 2015 take between 30seconds and 2minutes depending on how much there is to rebuild. Even changing target and running from scratch still benefits from ccache.

EDIT: my bad, it's already active, should I've looked before :)

mbed-os/.travis.yml

Line 31 in 8d9dabe

- ${HOME}/.ccache

ladislas · 2020-10-28T10:19:29Z

@0xc0170 that being said, I can't find where it's called with cmake... am I missing something?

we have the following at the top our main CMakeLists.txt:

find_program(CCACHE_PROGRAM ccache)
if(CCACHE_PROGRAM)
	set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
endif()

All the commands run through ccache.

0xc0170 · 2020-10-28T11:48:46Z

@ladislas That is another thing to look at (we do not yet use ccache with CMake). Please send a PR adding it

mbed-ci · 2020-10-28T14:46:03Z

Jenkins CI Test : ❌ FAILED

Build Number: 27 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌

0xc0170 · 2020-10-28T15:44:20Z

Configuration error (python cant find a path for BLe example) ?

Edit: found it, read below

0xc0170 · 2020-10-28T15:45:02Z

tools/test/examples/examples_cmake.json

+            "BLE_GattClient",
+            "BLE_GattServer",
+            "BLE_HeartRate",
+            "BLE_LED",


We currently support only BLE_LED, please remove the rest

mbed-ci · 2020-10-28T16:34:06Z

Jenkins CI Test : ❌ FAILED

Build Number: 28 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌

tools/test/examples/examples_lib.py

0xc0170 · 2020-10-29T10:37:41Z

Another thing to consider - ARMCLang will fail for our examples if we use older CMake version than 3.19.0 (currently only rc2 is out). This was found during #13827. To unblock 13827, we need this PR first.

Please install the latest CMake (3.19.0rc2, so ARMClang will compile).

Also another fix landed to feature-cmake (previouso ARM failures), feature-cmake should work once the latest cmake is used. Let's update and restart CI.

mbed-ci · 2020-10-29T15:53:16Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 29 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

0xc0170 · 2020-10-29T16:18:19Z

Looks like its ready, shout now or will merge to the feature branch soon.

tools/test/examples/examples_cmake.json

mbed-ci · 2020-10-29T17:43:48Z

Jenkins CI Test : ❌ FAILED

Build Number: 30 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️

jamesbeyond · 2020-10-29T17:48:51Z

GitHub hiccups , cause CI failed to clone repo. restart CI

hugueskamba · 2020-10-29T17:53:56Z

tools/test/examples/examples_lib.py

+                        if profiles:
+                            for profile in profiles:
+                                build_command_seq[0] += " --profile {}".format(profile)


You can also test all build profiles with mbed-tools.
You can use the --build-type optional argument of the build sub-command.

Cheers, good to know that.
But I as mentioned in Jaeden's comment, we are not going to introduce build multiple profile at this PR, as this will evolve more CI side code changes. We'll do that as an improvement in near future. In this PR we are only build the default profile which is development for now

mbed-ci · 2020-10-29T18:19:09Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 31 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

jamesbeyond added the do not merge label Aug 23, 2020

mergify bot added the release-version: feature branch label Aug 23, 2020

ciarmcom requested a review from a team August 23, 2020 17:30

ciarmcom added the needs: review label Aug 23, 2020

jamesbeyond added needs: work and removed needs: review labels Aug 24, 2020

hugueskamba force-pushed the feature-cmake branch from 129e697 to ed797cf Compare August 24, 2020 21:16

hugueskamba force-pushed the feature-cmake branch 2 times, most recently from 05cd574 to fa7523f Compare August 28, 2020 13:03

jamesbeyond force-pushed the dummy_cmake branch from 1cd248e to 0df7953 Compare August 28, 2020 14:00

jamesbeyond force-pushed the dummy_cmake branch from 85f836d to 3329b51 Compare September 1, 2020 15:36

hugueskamba force-pushed the feature-cmake branch from d91c3d7 to 5e4ec53 Compare September 2, 2020 11:09

hugueskamba force-pushed the feature-cmake branch 2 times, most recently from 8e34f86 to c7322d8 Compare September 7, 2020 20:42

jamesbeyond force-pushed the dummy_cmake branch 2 times, most recently from 1d130e5 to d2a8b8b Compare September 10, 2020 16:49

hugueskamba force-pushed the feature-cmake branch from 41dbb5b to 4c292c2 Compare September 11, 2020 14:24

TEST: remove cmake build test from TravisCI

593a08b

0xc0170 mentioned this pull request Oct 28, 2020

CMake: Use mbedtools build subcommand in travis CI #13821

Closed

ladislas mentioned this pull request Oct 28, 2020

CMake: Activate ccache #13824

Closed

TEST: add BLE example to cmake example json

ea9b876

0xc0170 reviewed Oct 28, 2020

View reviewed changes

Qinghao Shi added 2 commits October 28, 2020 16:02

TEST: fix a bug on example scripts

3f37bca

restrict BLE example only build BLE_LED

ca21805

hugueskamba reviewed Oct 28, 2020

View reviewed changes

tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved

0xc0170 mentioned this pull request Oct 29, 2020

CMake: ninja reponse files disabled for ARMClang on Windows #13827

Merged

0xc0170 added ready for merge and removed needs: work labels Oct 29, 2020

TEST: use mbed-tools build wrapper replace cmake build commands

8ce6c74

hugueskamba reviewed Oct 29, 2020

View reviewed changes

tools/test/examples/examples_cmake.json Show resolved Hide resolved

hugueskamba reviewed Oct 29, 2020

View reviewed changes

hugueskamba approved these changes Oct 30, 2020

View reviewed changes

0xc0170 merged commit 014dbce into ARMmbed:feature-cmake Oct 30, 2020

0xc0170 removed the ready for merge label Oct 30, 2020

ladislas mentioned this pull request Oct 30, 2020

CMake: Activate ccache #13834

Merged

CMake: add CI testing #13477

CMake: add CI testing #13477

Uh oh!

Conversation

jamesbeyond commented Aug 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Aug 23, 2020

Uh oh!

mbed-ci commented Aug 23, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Aug 24, 2020

Uh oh!

jamesbeyond commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Aug 24, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mergify bot commented Aug 24, 2020

Uh oh!

mergify bot commented Aug 28, 2020

Uh oh!

mergify bot commented Sep 2, 2020

Uh oh!

mbed-ci commented Sep 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Sep 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Sep 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Sep 11, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Sep 11, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 7 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

ladislas commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ladislas commented Oct 28, 2020

Uh oh!

0xc0170 commented Oct 28, 2020

Uh oh!

mbed-ci commented Oct 28, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 27 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Oct 28, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 28 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Uh oh!

0xc0170 commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamesbeyond commented Aug 23, 2020 •

edited

Loading

jamesbeyond commented Aug 24, 2020 •

edited

Loading

ladislas commented Oct 28, 2020 •

edited

Loading

0xc0170 commented Oct 28, 2020 •

edited

Loading

0xc0170 commented Oct 29, 2020 •

edited

Loading