Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE keys: fix psa_destroy_key; add Github issue numbers for missing code #221

Merged
merged 8 commits into from
Aug 14, 2019
Merged

SE keys: fix psa_destroy_key; add Github issue numbers for missing code #221

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4e73e9
Add some design notes about multipart operation structures
gilles-peskine-arm Aug 13, 2019
3f7cd62
Document better what wiping a key slot does not do
gilles-peskine-arm Aug 13, 2019
8fe253a
SE keys: test that psa_destroy_key removes the key from storage
gilles-peskine-arm Aug 13, 2019
caec278
SE keys: make psa_destroy_key remove the key from storage
gilles-peskine-arm Aug 13, 2019
9ce31c4
Note about destroying a key with other open handles
gilles-peskine-arm Aug 13, 2019
4b7f340
Clean up status code handling inside psa_destroy_key
gilles-peskine-arm Aug 13, 2019
5da7b3e
Drivers must have a psa_destroy_key method
gilles-peskine-arm Aug 13, 2019
c9d7f94
Add issue numbers for some missing parts of secure element support
gilles-peskine-arm Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/psa_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,7 @@ psa_status_t psa_destroy_key( psa_key_handle_t handle )
#endif /* MBEDTLS_PSA_CRYPTO_SE_C */

#if defined(MBEDTLS_PSA_CRYPTO_STORAGE_C)
if( slot->attr.lifetime == PSA_KEY_LIFETIME_PERSISTENT )
if( slot->attr.lifetime != PSA_KEY_LIFETIME_VOLATILE )
yanesca marked this conversation as resolved.
Show resolved Hide resolved
{
storage_status =
psa_destroy_persistent_key( slot->attr.id );
Expand Down