-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SE keys: fix psa_destroy_key; add Github issue numbers for missing code #221
Merged
gilles-peskine-arm
merged 8 commits into
ARMmbed:psa-api-1.0-beta
from
gilles-peskine-arm:annotate_todo_comments-20190813
Aug 14, 2019
Merged
SE keys: fix psa_destroy_key; add Github issue numbers for missing code #221
gilles-peskine-arm
merged 8 commits into
ARMmbed:psa-api-1.0-beta
from
gilles-peskine-arm:annotate_todo_comments-20190813
Aug 14, 2019
Commits on Aug 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b4e73e9 - Browse repository at this point
Copy the full SHA b4e73e9View commit details -
Document better what wiping a key slot does not do
When a key slot is wiped, a copy of the key material may remain in operations. This is undesirable, but does not violate the safety of the code. Tracked in https://github.com/ARMmbed/mbed-crypto/issues/86
Configuration menu - View commit details
-
Copy full SHA for 3f7cd62 - Browse repository at this point
Copy the full SHA 3f7cd62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fe253a - Browse repository at this point
Copy the full SHA 8fe253aView commit details -
Configuration menu - View commit details
-
Copy full SHA for caec278 - Browse repository at this point
Copy the full SHA caec278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce31c4 - Browse repository at this point
Copy the full SHA 9ce31c4View commit details -
Clean up status code handling inside psa_destroy_key
Adopt a simple method for tracking whether there was a failure: each fallible operation sets overall_status, unless overall_status is already non-successful. Thus in case of multiple failures, the function always reports whatever failed first. This may not always be the right thing, but it's simple. This revealed a bug whereby if the only failure was the call to psa_destroy_se_key(), i.e. if the driver reported a failure or if the driver lacked support for destroying keys, psa_destroy_key() would ignore that failure. For a key in a secure element, if creating a transaction file fails, don't touch storage, but close the key in memory. This may not be right, but it's no wronger than it was before. Tracked in ARMmbed#215
Configuration menu - View commit details
-
Copy full SHA for 4b7f340 - Browse repository at this point
Copy the full SHA 4b7f340View commit details -
Drivers must have a psa_destroy_key method
Drivers that allow destroying a key must have a destroy method. This test bug was previously not caught because of an implementation bug that lost the error triggered by the missing destroy method.
Configuration menu - View commit details
-
Copy full SHA for 5da7b3e - Browse repository at this point
Copy the full SHA 5da7b3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9d7f94 - Browse repository at this point
Copy the full SHA c9d7f94View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.