Adjust python 3 warning text and behaviour #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madchutney
approved these changes
Jun 19, 2019
| if very_verbose: | ||
| traceback.print_exc(file=sys.stdout) | ||
| error("Unknown Error: %s" % e, 255) | ||
| finally: |
There was a problem hiding this comment.
This was a strange thing to do in the first case, definitely good to remove it as it was generated even if there weren't any exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python 3 compatibility is not yet complete I've adjusted the warning message so that it no longer mentions the mbed-os version. Also the message is only printed as a warning once at the start. Previously it appeared again in a slightly different form if mbed CLI threw any exception.