Skip to content

Add back wrongly removed '\n' K-V pair sent to the device #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2016

Conversation

PrzemekWirkus
Copy link
Contributor

@PrzemekWirkus PrzemekWirkus commented Jun 23, 2016

Changes

Align how DUT and host together send and receive K-V messages between each other.

  • Together with Changing the key-value pair regex to include searches for new line #104 should significantly improve e.g, mbed_drivers::echo tests and DAPLink UX
  • While sending (TXD) K-V from htrun logger will not print white-space characters new line at the end
  • Updated README to reflect missing \n in K-V format
  • Note that greentea-client will always send newline character to host, see here.

Testting

mbedgt: test suite report:
+--------------+---------------+-------------------------+--------+--------------------+-------------+
| target       | platform_name | test suite              | result | elapsed_time (sec) | copy_method |
+--------------+---------------+-------------------------+--------+--------------------+-------------+
| K64F-GCC_ARM | K64F          | tests-mbed_drivers-echo | OK     | 23.73              | shell       |
+--------------+---------------+-------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+--------------+---------------+-------------------------+------------------+--------+--------+--------+--------------------+
| target       | platform_name | test suite              | test case        | passed | failed | result | elapsed_time (sec) |
+--------------+---------------+-------------------------+------------------+--------+--------+--------+--------------------+
| K64F-GCC_ARM | K64F          | tests-mbed_drivers-echo | Echo server: x16 | 1      | 0      | OK     | 1.65               |
| K64F-GCC_ARM | K64F          | tests-mbed_drivers-echo | Echo server: x32 | 1      | 0      | OK     | 3.19               |
| K64F-GCC_ARM | K64F          | tests-mbed_drivers-echo | Echo server: x64 | 1      | 0      | OK     | 6.29               |
+--------------+---------------+-------------------------+------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 3 OK
mbedgt: completed in 23.82 sec

@PrzemekWirkus PrzemekWirkus changed the title Add back wrongly removed \n K-V pair sent to the device Add back wrongly removed '\n' K-V pair sent to the device Jun 23, 2016
PrzemekWirkus referenced this pull request Jun 23, 2016
Simplifies logger (no need to send \n and logger will not log extra line)
@PrzemekWirkus
Copy link
Contributor Author

@mazimkhan @adbridge @ConorPKeegan FYI

@PrzemekWirkus PrzemekWirkus self-assigned this Jun 23, 2016
@bridadan
Copy link
Contributor

Tested locally for K64F and GCC_ARM,ARM, and IAR. Prevents bad state from echo test from ocurring and no regressions on other tests!

+1

@PrzemekWirkus PrzemekWirkus merged commit bd4e392 into master Jun 23, 2016
@PrzemekWirkus PrzemekWirkus deleted the issue_104 branch July 5, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants