Changing the key-value pair regex to include searches for new line #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the ongoing discussion about this DAPLink issue: ARMmbed/DAPLink#115
The behavior that reveal the issue in DAPLink was the following:
{{key;value}}\n
KiViBufferWalker
matches a key-value pair with the regex\{\{([\w\d_-]+);([^\}]+)\}\}
, which does not wait for the new the newline of the key-value pair:{{key;value}}
(note no\n
).\n
character.This patch forces the host test runner to wait for the
\n
character before matching any key-value pairs. This doesn't prevent every case where DAPLink might get into a bad state, but it avoids the particular case described above.@PrzemekWirkus @mazimkhan @adbridge
For more intimate details on the DAPLink issue, please see Russ's commit message on his proposed patch here: ARMmbed/DAPLink@1dcc1b1