#14: Vector graphics mode and infinite canvas #19
Conversation
shubertm
commented
Oct 5, 2023
•
shubertm
commented
- Vector graphics mode and infinite canvas #14
app/src/main/java/space/taran/arkmemo/data/repositories/GraphicalNotesRepo.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/space/taran/arkmemo/data/repositories/GraphicalNotesRepo.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/space/taran/arkmemo/data/repositories/GraphicalNotesRepo.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/build.gradle # app/src/main/java/space/taran/arkmemo/App.kt # app/src/main/java/space/taran/arkmemo/data/repositories/TextNotesRepository.kt # app/src/main/java/space/taran/arkmemo/data/viewmodels/EditTextNotesViewModel.kt # app/src/main/java/space/taran/arkmemo/files/FilePicker.kt # app/src/main/java/space/taran/arkmemo/preferences/MemoPreferences.kt # app/src/main/java/space/taran/arkmemo/ui/activities/MainActivity.kt # app/src/main/java/space/taran/arkmemo/ui/fragments/EditTextNotesFragment.kt # app/src/main/java/space/taran/arkmemo/ui/fragments/SettingsFragment.kt
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
app/src/main/java/space/taran/arkmemo/ui/adapters/NotesListAdapter.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/space/taran/arkmemo/data/repositories/TextNotesRepo.kt # app/src/main/java/space/taran/arkmemo/preferences/MemoPreferences.kt # app/src/main/java/space/taran/arkmemo/ui/activities/MainActivity.kt # app/src/main/java/space/taran/arkmemo/ui/viewmodels/NotesViewModel.kt
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
|
@ShubertMunthali I believe there are build errors at the moment in this branch (as below). 
|
| val pointList = point.split(COMMA) | ||
| val x = pointList[0].toFloat(); | ||
| val y = pointList[1].toFloat() | ||
| Log.d("svg-utils", "move to $point") | ||
| commandsString = commandsString.removePrefix("$SPACE$MOVE_TO$SPACE$point") |
There was a problem hiding this comment.
Please pay attention to these lint issues.
| val title = propertiesStorage.getProperties(id).titles.let { | ||
| if (it.isNotEmpty()) it.elementAt(0) else throw NoteTitlesException() |
There was a problem hiding this comment.
@ShubertMunthali This is not backward-compatible with previous app version.
That means, when there're existing notes which do not have any title, there will be a crash.
Thrown exception should be handled more elegantly in this case.
There was a problem hiding this comment.
Should we not throw exception? Then we can get the title from content, that's what old Memo did
There was a problem hiding this comment.
Should we not throw exception? Then we can get the title from content, that's what old Memo did
@ShubertMunthali If we throw it here, we should catch and handle it from the caller side, to avoid crash.
It's your call to decide it should be thrown out here or not, but IMHO there's no need to throw an exception here.
There was a problem hiding this comment.
It's ok, we will handle backward notes there
@ShubertMunthali Relating to UI/UX, I find the current 2 FABs quite boring when they stack on top of each other, as that occupies more screen space. |
|
When I edited a graphic note's title, it says It seems to be related to the special characters in the title, since I can reproduce that even with text note: https://recordit.co/qTpKM0jh1h |
| if (!isResumed) return@observe | ||
|
|
||
| if (it == SaveNoteResult.SUCCESS) { | ||
| toast(requireContext(), getString(R.string.ark_memo_note_saved)) |
There was a problem hiding this comment.
Same to this requireContext() as in https://github.com/ARK-Builders/ARK-Memo/pull/19/files#r1414715385.
Co-authored-by: Tuan Nguyen <tuancoltech@gmail.com>
@tuancoltech I understand the problem here. I will create new issue to describe how we should solve that bug or it should be solved in #22. I will add description there |
Looks pretty awesome. If we have some better options we should consider too. I like this at the moment. Cleans UI indeed :) |
|
@ShubertMunthali Sorry, I missed this. 
You mean all the fabs should be blue as well? Am not really sure but I guess there will be a special UI design later, that will consider all the themes. And just a suggestion, I think it will be better to specialize a task for that, it should tackle all the app UI/UX
|
|
@tuancoltech good observation about colors, but yes we'll work on it separately. |
