-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated title/description input fields #22
Comments
Partially solved in #19 |
@ShubertMunthali Thank you ~ |
Title and description should be persisted separate from content when save is clicked, this is to allow editing title and description independently. Right now they are not independent even though they are stored in separate storage. |
@ShubertMunthali I don't think title and description really myst be stored in separate storages. Single json storage for any extra data should be fine. What do you mean by dependency between title and description? It doesn't seem to be an issue |
This issue is mostly about logic of the UI. When a user creates a note, we wait until we have 20+ characters of the content and take it as the title. More sophisticated logic could be applied, too. No need to implement continuous tracking of the content to update the title, it seems to be over-engineering to me. |
@kirillt What I mean is, right now saving title and description is tied to save content. (title and description) are dependent on content in terms of saving logic. But they are stored in separate storage from content, not from each other :) |
Remember, when I added title field in #19. We discussed that instead of extracting title from content, we should provide default title and allow user to change it if they decide. And we have that implementation of the title now. What remains is the description field and to fix the saving logic. User should be able to save title only or description only or both whenever they are edited |
@kirillt What's your thought on this? Also, I'd like to make it more clear for below point:
-> This means we should provide user with a description field when creating a new note, but hide it from the note list UI? |
@tuancoltech the description field should be empty by default, UI should have an input for filling it. We could hide the description inpit with chevron or something else. The automatic title is an advanced version of plain default value (right now some text + date). |
@kirillt So, regarding note title, every newly created note will have a default title as text + date at the moment. |
As I see it, before the user typed 20 characters we have the default title. The default title is replaced by first 20 characters when the note becomes long enough. |
@tuancoltech Sorry for the change. After thinking through the flow I suggested before, I've realized we can throw "default title" away completely and implement simple "automatic title". Automatic title
Tangential thoughts |
@kirillt Thanks for making it clear. I'll implement it base on this idea. |
If user edits the content with empty title, title should reflect first 20 characters of the content.
When the user overwrites the title, it stops reflecting the content.
User should be able to create a description, too. But it should be hidden by default.
The text was updated successfully, but these errors were encountered: