Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Plotfile Regression (introduced in #2063) #2076

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix Plotfile Regression (introduced in #2063) #2076

merged 1 commit into from
Jun 2, 2021

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jun 2, 2021 •
edited by ax3l
Loading

Fix a regression from #2063

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers requested a review from ax3l June 2, 2021 19:13
@ax3l ax3l mentioned this pull request Jun 2, 2021
Merged
5 tasks
@ax3l ax3l added the bug label Jun 2, 2021
@ax3l ax3l changed the title Fix bug introduced in PR 2063 Fix Plotfile Regression (introduced in #2063) Jun 2, 2021
ax3l
ax3l approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes the issue I saw with WarpX in ECP-WarpX/WarpX#1998 🎉

@ax3l ax3l merged commit 2acc1ca into AMReX-Codes:development Jun 2, 2021
@ax3l ax3l mentioned this pull request Jun 2, 2021
Merged
5 tasks
@ax3l ax3l mentioned this pull request Sep 3, 2021
Merged
WeiqunZhang pushed a commit to AMReX-Codes/amrex-tutorials that referenced this pull request Sep 6, 2021
@ax3l
Update: SetupCUDA (#25)
478e6e6 
Only needed for older CMake versions.

Refs.:
- AMReX-Codes/amrex#2012 (feature added to AMReX 21.06+)
- AMReX-Codes/amrex#2074 (regression currently in review, needs to be merged; update: merged)
- Hi-PACE/hipace#522 (same logic for HiPACE++)
- AMReX-Codes/amrex#2076 (just a regression on the way)
- AMReX-Codes/amrex#2077 filter out unsupported SMs, e.g. if we fall back to heuristics
- ECP-WarpX/WarpX#1998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @ax3l