CMake 3.20+ CUDA: Policy & Include #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not include the deprecated CUDA setup with CMake 3.20+ and support new policy for CUDA_ARCHITECTURES. Also fix errors of the kind: ``` ERROR: set_target_properties called with incorrect number of arguments. Value in AMREX_CUDA_ARCHS is 53;60;61;70;75;80;86;86 ``` by quoting the semicolon-separated list.
9 tasks
WeiqunZhang
approved these changes
Jun 2, 2021
5 tasks
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Jun 2, 2021
Update AMReX to c099e342334c01c8fa2055b2e1e806c62bdf3035 This includes the regression fix for CMake 3.20+ with CUDA: AMReX-Codes/amrex#2074
5 tasks
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex-tutorials
that referenced
this pull request
Sep 6, 2021
Only needed for older CMake versions. Refs.: - AMReX-Codes/amrex#2012 (feature added to AMReX 21.06+) - AMReX-Codes/amrex#2074 (regression currently in review, needs to be merged; update: merged) - Hi-PACE/hipace#522 (same logic for HiPACE++) - AMReX-Codes/amrex#2076 (just a regression on the way) - AMReX-Codes/amrex#2077 filter out unsupported SMs, e.g. if we fall back to heuristics - ECP-WarpX/WarpX#1998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not include the deprecated CUDA setup with CMake 3.20+ and support new policy for CUDA_ARCHITECTURES.
Also fix errors of the kind:
by quoting the semicolon-separated list.
Additional background
Those are regressions to #2012 that appear with our modernized logic in CMake 3.20+ with CUDA.
I saw those regressions with HiPACE++.
Checklist
The proposed changes: