Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 17, 2025

Fixes #3046.

Relax the faulty check. Better to track more root functions than missing some. Will optimize after #3031.

…argets

Fixes AMICI-dev#3046.

Relax the faulty check. Better to track more root functions than missing some.
Will optimize after AMICI-dev#3031.
@dweindl dweindl changed the title DEModel._expr_is_time_dependent not accounting for event assignment t… Fix DEModel._expr_is_time_dependent not accounting for event assignment targets Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.45%. Comparing base (baed9cd) to head (88053e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/de_model.py 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
- Coverage   78.10%   77.45%   -0.65%     
==========================================
  Files         311      311              
  Lines       20580    20582       +2     
  Branches     1499     1499              
==========================================
- Hits        16073    15941     -132     
- Misses       4497     4631     +134     
  Partials       10       10              
Flag Coverage Δ
cpp 70.71% <85.71%> (-0.01%) ⬇️
cpp_python 37.18% <71.42%> (-0.01%) ⬇️
petab 45.83% <71.42%> (-0.03%) ⬇️
petab_sciml 13.75% <0.00%> (-0.01%) ⬇️
python 69.37% <85.71%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 91.53% <85.71%> (-0.12%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 17, 2025 19:53
@dweindl dweindl requested a review from a team as a code owner November 17, 2025 19:53
@dweindl dweindl added this pull request to the merge queue Nov 17, 2025
@dweindl dweindl self-assigned this Nov 17, 2025
Merged via the queue into AMICI-dev:main with commit 72a7a92 Nov 17, 2025
31 of 32 checks passed
@dweindl dweindl deleted the gh-3046-fix-const-trigger branch November 17, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEModel._expr_is_time_dependent does not account for event assignment targets

2 participants