Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 13, 2025

This should hopefully allow for more efficient computation of root-derivatives by avoiding flattening w into root which, so far, made computing drootdt_total prohibitively expensive in case of large w dependencies in root.

Closes #3022.

@dweindl dweindl self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 68.75000% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.55%. Comparing base (8fc33dc) to head (c95ca0e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
models/model_events_py/model_events_py.h 54.54% 5 Missing ⚠️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 16.66% 5 Missing ⚠️
...ls/model_nested_events_py/model_nested_events_py.h 54.54% 5 Missing ⚠️
models/model_neuron_py/model_neuron_py.h 50.00% 5 Missing ⚠️
models/model_robertson_py/model_robertson_py.h 16.66% 5 Missing ⚠️
models/model_steadystate_py/model_steadystate_py.h 16.66% 5 Missing ⚠️
models/model_calvetti_py/model_calvetti_py.h 50.00% 4 Missing ⚠️
models/model_dirac_py/model_dirac_py.h 60.00% 4 Missing ⚠️
models/model_dirac_py/deltaqB.cpp 0.00% 1 Missing ⚠️
models/model_events_py/deltaqB.cpp 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   78.14%   77.55%   -0.59%     
==========================================
  Files         311      311              
  Lines       20593    20622      +29     
  Branches     1499     1501       +2     
==========================================
- Hits        16092    15993      -99     
- Misses       4491     4619     +128     
  Partials       10       10              
Flag Coverage Δ
cpp 70.76% <68.75%> (+<0.01%) ⬆️
cpp_python 37.24% <34.02%> (+0.06%) ⬆️
petab 45.86% <78.57%> (+0.05%) ⬆️
petab_sciml 13.76% <12.50%> (-0.04%) ⬇️
python 69.48% <68.75%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/model.h 78.04% <ø> (ø)
include/amici/model_dae.h 80.00% <ø> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
models/model_calvetti_py/explicit_roots.cpp 100.00% <100.00%> (ø)
models/model_calvetti_py/root.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/explicit_roots.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/root.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/stau.cpp 100.00% <100.00%> (ø)
models/model_events_py/explicit_roots.cpp 100.00% <100.00%> (ø)
... and 31 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the gh-3022-w-in-froot branch 10 times, most recently from 3fb84cd to ffb787d Compare November 15, 2025 21:08
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 17, 2025
…argets

Fixes AMICI-dev#3046.

Relax the faulty check. Better to track more root functions than missing some.
Will optimize after AMICI-dev#3031.
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 17, 2025
…argets

Fixes AMICI-dev#3046.

Relax the faulty check. Better to track more root functions than missing some.
Will optimize after AMICI-dev#3031.
github-merge-queue bot pushed a commit that referenced this pull request Nov 17, 2025
…argets (#3047)

Fixes #3046.

Relax the faulty check. Better to track more root functions than missing some.
Will optimize after #3031.
@dweindl dweindl force-pushed the gh-3022-w-in-froot branch 2 times, most recently from 8ef044b to 36b41f6 Compare November 18, 2025 08:45
This should hopefully allow for more efficient computation of `root`-derivatives
by avoiding flattening `w` into `root` which, so far, made computing `drootdt_total`
prohibitively expensive in case of large `w` dependencies in `root`.
@dweindl dweindl marked this pull request as ready for review November 18, 2025 15:57
@dweindl dweindl requested a review from a team as a code owner November 18, 2025 15:57
@dweindl dweindl enabled auto-merge November 18, 2025 17:51
@dweindl dweindl added this pull request to the merge queue Nov 18, 2025
Merged via the queue into AMICI-dev:main with commit 35c3492 Nov 18, 2025
51 of 76 checks passed
@dweindl dweindl deleted the gh-3022-w-in-froot branch November 18, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let Model::froot depend on w

2 participants