-
Notifications
You must be signed in to change notification settings - Fork 32
Let froot depend on w
#3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Let froot depend on w
#3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31b0a07 to
2ccb30d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 78.14% 77.55% -0.59%
==========================================
Files 311 311
Lines 20593 20622 +29
Branches 1499 1501 +2
==========================================
- Hits 16092 15993 -99
- Misses 4491 4619 +128
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3fb84cd to
ffb787d
Compare
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 17, 2025
…argets Fixes AMICI-dev#3046. Relax the faulty check. Better to track more root functions than missing some. Will optimize after AMICI-dev#3031.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 17, 2025
…argets Fixes AMICI-dev#3046. Relax the faulty check. Better to track more root functions than missing some. Will optimize after AMICI-dev#3031.
43f1ddb to
71510e0
Compare
8ef044b to
36b41f6
Compare
This should hopefully allow for more efficient computation of `root`-derivatives by avoiding flattening `w` into `root` which, so far, made computing `drootdt_total` prohibitively expensive in case of large `w` dependencies in `root`.
36b41f6 to
c95ca0e
Compare
FFroehlich
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully allow for more efficient computation of
root-derivatives by avoiding flatteningwintorootwhich, so far, made computingdrootdt_totalprohibitively expensive in case of largewdependencies inroot.Closes #3022.