Skip to content

Fix assignmentRules2observables - skip non-assignment-rule targets #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Feb 6, 2023
Merged

Fix assignmentRules2observables - skip non-assignment-rule targets #1973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions python/sdist/amici/sbml_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,11 +2140,14 @@ def assignmentRules2observables(sbml_model: sbml.Model,
})
"""
observables = {}
for p in sbml_model.getListOfParameters():
parameter_id = p.getId()
if filter_function(p):
for rule in sbml_model.getListOfRules():
if rule.getTypeCode() != sbml.SBML_ASSIGNMENT_RULE:
continue
parameter_id = rule.getVariable()
if (p := sbml_model.getParameter(parameter_id)) \
and filter_function(p):
observables[parameter_id] = {
'name': p.getName() if p.isSetName() else p.getId(),
'name': p.getName() if p.isSetName() else parameter_id,
'formula': sbml_model.getAssignmentRuleByVariable(
parameter_id
).getFormula()
Expand Down