Skip to content

Fix assignmentRules2observables - skip non-assignment-rule targets - #1973

Merged
dweindl merged 1 commit into
developfrom
fix_asr2obs
Feb 6, 2023
Merged

Fix assignmentRules2observables - skip non-assignment-rule targets#1973
dweindl merged 1 commit into
developfrom
fix_asr2obs

Conversation

@dweindl

@dweindl dweindl commented Feb 2, 2023

Copy link
Copy Markdown
Member

The filter function should only be called on AssignmentRule targets. Currently it's called on all parameters.

The filter function should only be called on AssignmentRule targets.
Currently it's called on all parameters.
@dweindl
dweindl requested a review from a team as a code owner February 2, 2023 08:08
@codecov

codecov Bot commented Feb 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1973 (42f10b3) into develop (97f7438) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1973      +/-   ##
===========================================
+ Coverage    76.01%   76.04%   +0.02%     
===========================================
  Files           76       76              
  Lines        12981    12983       +2     
===========================================
+ Hits          9868     9873       +5     
+ Misses        3113     3110       -3     
Flag Coverage Δ
cpp 73.22% <ø> (+0.04%) ⬆️
petab 59.72% <0.00%> (-0.03%) ⬇️
python 68.93% <80.00%> (-0.01%) ⬇️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/sbml_import.py 80.95% <80.00%> (-0.09%) ⬇️
src/sundials_matrix_wrapper.cpp 80.61% <0.00%> (ø)
src/model.cpp 78.49% <0.00%> (+0.06%) ⬆️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl
dweindl merged commit de44941 into develop Feb 6, 2023
@dweindl
dweindl deleted the fix_asr2obs branch February 6, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants