Skip to content

Fix get_model for direct import of swig interface - #1969

Merged
dweindl merged 1 commit into
developfrom
fix_getmodel
Jan 31, 2023
Merged

Fix get_model for direct import of swig interface#1969
dweindl merged 1 commit into
developfrom
fix_getmodel

Conversation

@dweindl

@dweindl dweindl commented Jan 31, 2023

Copy link
Copy Markdown
Member

Fixup for #1932

This fixes importing the swig wrapper for a model directly (not via the package).

Fixup for #1932

This fixes importing the swig wrapper for a model directly (not via the package).
@dweindl
dweindl requested a review from a team as a code owner January 31, 2023 14:41
@codecov

codecov Bot commented Jan 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1969 (9f6f871) into develop (b61abb6) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1969      +/-   ##
===========================================
+ Coverage    75.98%   76.00%   +0.02%     
===========================================
  Files           76       76              
  Lines        12984    12984              
===========================================
+ Hits          9866     9869       +3     
+ Misses        3118     3115       -3     
Flag Coverage Δ
cpp 73.18% <ø> (+0.03%) ⬆️
petab 59.71% <ø> (ø)
python 68.97% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/model.cpp 78.49% <0.00%> (+0.06%) ⬆️
src/sundials_matrix_wrapper.cpp 80.61% <0.00%> (+0.40%) ⬆️

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dweindl
dweindl merged commit a43ae7f into develop Jan 31, 2023
@dweindl
dweindl deleted the fix_getmodel branch January 31, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants