Make model module accessible from model instance - #1932
Merged
Conversation
This makes it more convenient to create a new (unmodified) model instance, or to find out where the model files are located. Also adds a snake_case version of `getModel`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1932 +/- ##
===========================================
+ Coverage 75.90% 75.99% +0.09%
===========================================
Files 76 76
Lines 12970 12970
===========================================
+ Hits 9845 9857 +12
+ Misses 3125 3113 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Jan 16, 2023
FFroehlich
left a comment
FFroehlich
left a comment
Member
There was a problem hiding this comment.
👍 neat, check path (test) for one of the test models?
Member
Author
|
Added a test. Ideally, this whole thing would be handled by returning an instance of the ModelXXXX Python class by |
|
Kudos, SonarCloud Quality Gate passed! |
dweindl
added a commit
that referenced
this pull request
Jan 31, 2023
Fixup for #1932 This fixes importing the swig wrapper for a model directly (not via the package).
dweindl
added a commit
that referenced
this pull request
Jan 31, 2023
Fixup for #1932 This fixes importing the swig wrapper for a model directly (not via the package).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it more convenient to create a new (unmodified) model instance, or to find out where the model files are located.
Also adds a snake_case version of
getModel.