Skip to content

Release 0.11.29 - #1793

Merged
dweindl merged 10 commits into
masterfrom
release_0.11.29
May 6, 2022
Merged

Release 0.11.29#1793
dweindl merged 10 commits into
masterfrom
release_0.11.29

Conversation

@dweindl

@dweindl dweindl commented May 6, 2022

Copy link
Copy Markdown
Member

No description provided.

Fabian Fröhlich and others added 8 commits April 20, 2022 13:33
Setuptools [recently changed (>=v62.1.0)](pypa/setuptools@1c23f5e) the name of the temporary build directory and lcov fails trying to access a non-existent directory (`geninfo: ERROR: cannot read /home/runner/work/AMICI/AMICI/python/sdist/build/temp.linux-x86_64-3.8/amici/src!`). This fixes that.
…Etab parameter mapping (#1783)

* Fix logging error if no measurements in PEtab problem
* Fix type handling in PEtab parameter mapping (support supplying simulation conditions as a dictionary)

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Show more informative warnings when encountering `NaN` or `inf` in model quantities (include IDs where available and provide 2D indices instead of flat indices).

Closes #1375
PEtab does currently not allow observables in noiseFormula and AMICI cannot handle states in sigma expressions. Therefore, where possible, replace species occurring in the error model definition by observableIds.

See also #1788
* initial implementation, fixes #1760

* fixup

* fixup

* fixup

* fix doc

* fix doc

* fixup swig

* fixup sbml import

* add sensitivity check, fixup time-independent triggers

* fixup

* fixup

* fixup

* fixup parameter event assignments

* update test stats

* Apply suggestions from code review

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>

Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@dweindl
dweindl requested a review from FFroehlich May 6, 2022 12:14
@codecov

codecov Bot commented May 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1793 (0bdf04e) into master (da34367) will decrease coverage by 5.05%.
The diff coverage is 50.69%.

❗ Current head 0bdf04e differs from pull request most recent head 1952697. Consider uploading reports for the commit 1952697 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   78.05%   73.00%   -5.06%     
==========================================
  Files          74       71       -3     
  Lines       12161    12256      +95     
==========================================
- Hits         9492     8947     -545     
- Misses       2669     3309     +640     
Flag Coverage Δ
cpp 74.33% <50.79%> (-0.67%) ⬇️
petab ?
python 68.17% <41.66%> (-0.25%) ⬇️
sbmlsuite 88.49% <76.92%> (+1.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/forwardproblem.h 100.00% <ø> (ø)
include/amici/misc.h 80.76% <ø> (ø)
include/amici/model.h 56.00% <ø> (ø)
include/amici/sundials_matrix_wrapper.h 89.23% <ø> (ø)
python/amici/petab_import.py 0.00% <0.00%> (-72.39%) ⬇️
python/amici/petab_objective.py 0.00% <0.00%> (-94.33%) ⬇️
src/model_dae.cpp 46.42% <0.00%> (ø)
src/model_ode.cpp 70.99% <0.00%> (ø)
src/model.cpp 80.71% <34.19%> (-5.61%) ⬇️
src/solver_idas.cpp 37.72% <40.00%> (-0.07%) ⬇️
... and 26 more

@dweindl
dweindl force-pushed the release_0.11.29 branch from 0bdf04e to 1952697 Compare May 6, 2022 14:57
@dweindl
dweindl merged commit 8fe8884 into master May 6, 2022
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

4.8% 4.8% Coverage
0.0% 0.0% Duplication

@dweindl
dweindl deleted the release_0.11.29 branch August 23, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants