Conversation
Closed
cfe4d7b to
67ddd8f
Compare
SeanBryan51
commented
Jan 30, 2024
SeanBryan51
commented
Jan 30, 2024
Collaborator
|
Need CABLE-LSM/CABLE#200 to be merged before this PR. |
Collaborator
Author
|
Update: CABLE-LSM/CABLE#200 has now been merged. There is another pull request (CABLE-LSM/CABLE#216) which should remove the need to specify an MPI compiler wrapper in the spack package definition. It might be best if we also wait for this to be implemented first. |
218d96c to
e3939b9
Compare
harshula
reviewed
Mar 7, 2024
harshula
approved these changes
Mar 7, 2024
56de159 to
cb63a93
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a spack package for CABLE (offline configuration).
This change should follow after a CMake based build system has been implemented, see: CABLE-LSM/CABLE#200, CABLE-LSM/CABLE#216.
Package installation tested with:
Fixes #58