fix(content): fishing anims and sounds correctly match old videos

[tannerdino]

• adds lava eel fishing for the wilderness fishing locs :)
• fixes up fishing loc fishing at the waterfall
• refactor all of fishing to remove the need of %skill_anim and %skill_sound
• ensures sounds are played correctly for all fishing spots (one sound on first interaction)
• further animation timing fixes to match old videos

Matching it with old videos just so happened to fix the "fishing from far away" bug... That bug couldve been authentic but the blog post is really vague about it: Fixed a bug with fishing, where the animation didn't always run in the right place, and where large crowds in one place made the fish vanish.

It was fixed with the blocks of code that looks like:

if (%action_delay < map_clock) {
    %action_delay = calc(map_clock + 4);
    p_oploc(1);
    return;
}

In osrs, all fishing spots except for fly fishing spots have this. However, fly fishing does have it in this old video:

2025-02-19.13-54-06.mp4

On tick 1 he turns towards it. Tick 2 "You cast out your line..." is displayed. Tick 3 "You attempt to catch a fish." is displayed. I think this behavior for fly fishing was removed in this update for rainbow fish. This video lines up with the dates as well.

The main question is, what does the animation didn't always run in the right place even mean lol. Does this mean that the block of code in question doesnt exist for basically all fishing spots?

I've ultimately went with that the blog post is too vague, and went with the behavior that matches old videos 1:1.

I'd also like to mention that this doesnt effect tick manipulation methods at all basically