fix(engine): add safety checks to savefile loading/storing #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for some reason we try to access savefile for a player that should have one, and it's either absent from the filesystem or has invalid data, we now reject the login attempt under a generic "Please try again" message. Previously, there were no sanity checks on reading the savefile data, or if we didn't find a savefile for a player which should have one (`logout_time != null`). In theory, if something went wrong here, it would be sent to the player as a completely reset tutorial island account. Then, when they logged out, the new savefile would be written.
A last-ditch effort to prevent overwriting an existing save with one that has been reset back to tutorial island.
locked-chest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes which should increase robustness of the login/logout processing.
.sav.)(existingSave.playtime > newSave.playtime); this should prevent such cases that have somehow been resetted from being permanently saved on disk.