fix(content): dragon slayer softlock #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGould1
changed the title
kylmp
reviewed
Feb 6, 2025
| @@ -184,7 +184,7 @@ if ($choice = 1) { | |||
| ~chatnpc("<p,neutral>I said I would and old Ned is a man of his word!"); // osrs | |||
| ~chatnpc("<p,quiz>So where's your ship?"); | |||
| @ned_so_wheres_your_ship; | |||
| } else if (%dragon_progress = ^quest_dragon_ned_given_map) { | |||
| } else if ((%dragon_progress = ^quest_dragon_ned_given_map | %dragon_progress = ^quest_dragon_sailed_to_crandor)) { | |||
There was a problem hiding this comment.
no need to change but the extra parenthesis are unnecessary
There was a problem hiding this comment.
Oops yeah noted for next time :)
Pazaz
added a commit
that referenced
this pull request
Feb 8, 2025
## Client Changes ### Features * #1195 ## Content Changes ### Fixes * #1196 * #1198 * #1199 * #1200 * #1201 * #1202 * #1205 * #1208 * #1209 * #1210 * #1211 * #1216 * #1224 * #1225 * #1225 * #1226 * #1227 * #1229 * #1230 ## Engine Changes ### Fixes * #1197 * #1204 * #1206 * #1207 * #1212 * #1213 * #1217 * #1218 * #1222 * #1228 * processLogout should be safer * Log random event name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A player (bog) died while fighting elvarg and could not get back to crandor.
I think there were two issues
A dialogue issue where Ned asks for a map, despite you handing it to him. This is because we check only for
quest_dragon_ned_given_maphowever once sailed to crandor you're set toquest_dragon_sailed_to_crandorThe dialogue handler for ned would default to
@ned_dragon_slayer_hiredwhich does not allow the player to re-hire ned. I changed it so that the dialogue handler will first check to see if you have been to crandor.Now players should be able to re-hire ned, fix the ship, and meet him in port sarim.